Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KeepLast as valid value for no data & exec err state #1528

Merged
merged 1 commit into from
May 13, 2024

Conversation

theSuess
Copy link
Member

@theSuess theSuess commented May 10, 2024

Closes: #1513

@theSuess theSuess force-pushed the feat/alert-rule-keep-last branch from 0e4412d to b2f7fe0 Compare May 10, 2024 11:06
Copy link
Collaborator

@weisdd weisdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the OLM setup still depends on the manifests from this repository, then you'd need to also run VERSION=5.9.0 make bundle/redhat to update the remaining CRD.

@NissesSenap NissesSenap requested a review from weisdd May 13, 2024 09:09
@theSuess theSuess force-pushed the feat/alert-rule-keep-last branch from b2f7fe0 to 89c743a Compare May 13, 2024 12:32
@weisdd weisdd merged commit fa89d70 into master May 13, 2024
10 checks passed
@weisdd weisdd deleted the feat/alert-rule-keep-last branch May 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrafanaAlertRuleGroup Unsupported "KeepLast" value for noDataState and execErrState
3 participants