Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrafanaAlertRuleGroup Unsupported "KeepLast" value for noDataState and execErrState #1513

Closed
marcantoine-bibeau opened this issue May 1, 2024 · 0 comments · Fixed by #1528
Closed

GrafanaAlertRuleGroup Unsupported "KeepLast" value for noDataState and execErrState #1513

marcantoine-bibeau opened this issue May 1, 2024 · 0 comments · Fixed by #1528
Assignees
@theSuess
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcantoine-bibeau
Copy link

Describe the bug
Error when applying a GrafanaAlertRuleGroup with noDataState=KeepLast or .execErrState=KeepLast

Version
v5.8.1

To Reproduce

  • Create an Alert Rule from UI
  • In section 3. Set evaluation behavior, "Configure no data and error handling", set both to "KeepLast"
  • Export alert rule to yaml
  • Create a GrafanaAlertRuleGroup CR with exported data

Expected behavior
Rule should be created

Screenshots
image

image

Runtime (please complete the following information):

  • OS: Linux
  • Grafana Operator Version v5.8.1
  • Environment: Kubernetes
  • Deployment type: running the operator on Kubernetes with Grafana Cloud

Additional context
@marcantoine-bibeau marcantoine-bibeau added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 1, 2024
@theSuess theSuess self-assigned this May 6, 2024
@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 6, 2024
@theSuess theSuess mentioned this issue May 8, 2024
Closed
theSuess added a commit that referenced this issue May 10, 2024
@theSuess
feat: add KeepLast as valid value for no data & exec err state
0e4412d 
implements #1513
@theSuess theSuess mentioned this issue May 10, 2024
Merged
theSuess added a commit that referenced this issue May 10, 2024
@theSuess
feat: add KeepLast as valid value for no data & exec err state
b2f7fe0 
implements #1513
theSuess added a commit that referenced this issue May 13, 2024
@theSuess
feat: add KeepLast as valid value for no data & exec err state
89c743a 
implements #1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theSuess theSuess

Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add KeepLast as valid value for no data & exec err state grafana/grafana-operator
2 participants
@theSuess @marcantoine-bibeau