Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): verify golangci-lint config #1518

Merged
merged 3 commits into from
May 5, 2024
Merged

chore(workflows): verify golangci-lint config #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db703f1
chore(workflows): verify golangci-lint config
weisdd May 5, 2024
622c9b2
chore(workflows): bump golangci-lint to 1.57.2
weisdd May 5, 2024
6d493bd
chore(workflows): remove deprecated options from golangci-lint config
weisdd May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pr-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ jobs:
- name: golangci-lint
uses: golangci/[email protected]
with:
version: "v1.56.2"
version: "v1.57.2"

- name: Verify golangci-lint config
run: |
golangci-lint config verify

test:
runs-on: ubuntu-latest
Expand Down
9 changes: 0 additions & 9 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,10 @@ linters-settings:
misspell:
locale: US

unused:
go: "1.19"

unparam:
check-exported: true

govet:
check-shadowing: false

gosimple:
go: "1.19"
checks: ["all"]

errorlint:
Expand Down Expand Up @@ -88,13 +81,11 @@ linters-settings:

nolintlint:
allow-unused: false
allow-leading-space: true
allow-no-explanation: []
require-explanation: false
require-specific: false

staticcheck:
go: "1.19"
checks: ["all"]

thelper:
Expand Down