Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workflows): verify golangci-lint config #1518

Merged
merged 3 commits into from
May 5, 2024
Merged

chore(workflows): verify golangci-lint config #1518

merged 3 commits into from
May 5, 2024

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented May 5, 2024 •
edited
Loading

golangci-lint has a built-in functionality to validate its config for presence of deprecated options. This PR adds a verification step. Example:

image

Additional changes:

  • bump version to v1.57.2;
  • remove deprecated options (NOTE: we no longer need to pin certain linters to specific go versions, it's all detected automatically through go.mod).

@weisdd weisdd merged commit b6f5a0d into master May 5, 2024
10 checks passed
@weisdd weisdd deleted the chore/verify-golangci-lint-config branch May 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@theSuess theSuess Awaiting requested review from theSuess theSuess is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weisdd @NissesSenap