Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP in attacher #974

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add PHP in attacher #974

merged 1 commit into from
Jun 27, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 27, 2024

After adding detection of language detection for PHP in #970, quoteservice disappeared
in notel demo. I forgot to add this in the attacher, so this probably will fix the issue.

@marctc marctc requested review from grcevski and mariomac as code owners June 27, 2024 11:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (7c41a6e) to head (e0ab8a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   80.34%   80.56%   +0.22%     
==========================================
  Files         134      134              
  Lines       10563    10591      +28     
==========================================
+ Hits         8487     8533      +46     
+ Misses       1571     1556      -15     
+ Partials      505      502       -3     
Flag Coverage Δ
integration-test 55.79% <100.00%> (-0.02%) ⬇️
k8s-integration-test 58.95% <100.00%> (-0.03%) ⬇️
oats-test 36.08% <100.00%> (+0.13%) ⬆️
unittests 50.60% <0.00%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daleee

@marctc marctc merged commit f877c64 into main Jun 27, 2024
6 checks passed
@marctc marctc deleted the add_php_to_attacher branch June 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants