Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection for PHP language #970

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Add detection for PHP language #970

merged 2 commits into from
Jun 26, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 26, 2024

  • Added support to detect PHP services. Simply checks that PHP is in the path of executable.
  • Update semconv in svc.go to use semconv for Rust

@marctc marctc requested review from grcevski and mariomac as code owners June 26, 2024 11:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.34%. Comparing base (b3ed5a5) to head (b8e766c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   80.26%   80.34%   +0.08%     
==========================================
  Files         134      134              
  Lines       10554    10563       +9     
==========================================
+ Hits         8471     8487      +16     
+ Misses       1575     1571       -4     
+ Partials      508      505       -3     
Flag Coverage Δ
integration-test 55.87% <100.00%> (+0.17%) ⬆️
k8s-integration-test 58.84% <15.38%> (-0.10%) ⬇️
oats-test 35.94% <15.38%> (-0.04%) ⬇️
unittests 48.79% <30.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 7c41a6e into main Jun 26, 2024
6 checks passed
@marctc marctc deleted the add_php_detection branch June 26, 2024 15:00
@marctc marctc mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants