Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL: removing metrics from removed entities #948

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

mariomac
Copy link
Contributor

In OTEL, previous removal mechanism only removed old metrics from the same metrics provider instance. We can't remove the whole metrics provider when a service goes down (the OTEL API does not provide a mechanism for it without killing the whole metrics exporter).

This PR provides its own expiration mechanism for providers that explicitly removes all the existing metrics of a single metrics provider.

@mariomac mariomac requested review from grcevski and marctc as code owners June 19, 2024 15:58
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very cool!

@mariomac
Copy link
Contributor Author

Tested also manually before merging and checked that it works

@mariomac mariomac merged commit 1ab104a into grafana:main Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants