OTEL: removing metrics from removed entities #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OTEL, previous removal mechanism only removed old metrics from the same metrics provider instance. We can't remove the whole metrics provider when a service goes down (the OTEL API does not provide a mechanism for it without killing the whole metrics exporter).
This PR provides its own expiration mechanism for providers that explicitly removes all the existing metrics of a single metrics provider.