Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiring OTel histogram metrics #823

Closed
dashpole opened this issue May 8, 2024 · 2 comments
Closed

Expiring OTel histogram metrics #823

dashpole opened this issue May 8, 2024 · 2 comments

Comments

@dashpole
Copy link
Contributor

dashpole commented May 8, 2024

As discussed during the community call today, the opentelemetry expiry only handles counters, and not histograms: https://github.com/grafana/beyla/blob/main/pkg/internal/netolly/export/otel/expirer.go#L54. This is because synchronous APIs in OTel do not have delete methods on synchronous instruments: open-telemetry/opentelemetry-specification#3062.

The workaround you can use for OTel is to use the SDK's Producer interface to provide aggregated histogram metric data. Alternatively, you could implement the Prometheus Collector interface (which would also solve this for the Prometheus export, and then use the prometheus bridge (go.opentelemetry.io/contrib/bridges/prometheus, which implements the Producer interface, to plug the histogram into the OTel SDK.

@mariomac
Copy link
Contributor

mariomac commented Jul 4, 2024

Addressed in:

Will be public in Beyla 1.7, but you can try it now in the main docker tag.

@mariomac mariomac closed this as completed Jul 4, 2024
@dashpole
Copy link
Contributor Author

dashpole commented Jul 8, 2024

looks very cool, and I like that it includes staleness markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants