-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using experimental OTEL API for removing metrics #937
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 79.15% 72.16% -7.00%
==========================================
Files 131 130 -1
Lines 10104 10110 +6
==========================================
- Hits 7998 7296 -702
- Misses 1597 2188 +591
- Partials 509 626 +117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excellent!
It replaces the current observable-based OTEL api for removing counters and gauges to a general-purpose experimental API that also allows removing Histograms: https://github.com/grafana/opentelemetry-go/tree/v1.27.0-grafana.1 (kudos to @pyohannes !).
Tasks: