Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using experimental OTEL API for removing metrics #937

Merged
merged 10 commits into from
Jun 17, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jun 17, 2024

It replaces the current observable-based OTEL api for removing counters and gauges to a general-purpose experimental API that also allows removing Histograms: https://github.com/grafana/opentelemetry-go/tree/v1.27.0-grafana.1 (kudos to @pyohannes !).

Tasks:

  • Update documentation.
  • Testing histograms removal for the app metrics exporter.

@mariomac mariomac requested review from grcevski and marctc as code owners June 17, 2024 10:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 81.73077% with 38 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (b73549b) to head (1a8f7f4).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/internal/export/otel/metrics_proc.go 82.85% 6 Missing and 6 partials ⚠️
pkg/internal/export/otel/expirer.go 69.23% 7 Missing and 1 partial ⚠️
pkg/internal/export/prom/prom_proc.go 50.00% 8 Missing ⚠️
pkg/internal/export/prom/prom.go 68.42% 6 Missing ⚠️
pkg/internal/export/otel/metrics_net.go 88.88% 1 Missing and 1 partial ⚠️
pkg/internal/export/expire/expiry_map.go 75.00% 1 Missing ⚠️
pkg/internal/export/prom/expirer.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   79.15%   72.16%   -7.00%     
==========================================
  Files         131      130       -1     
  Lines       10104    10110       +6     
==========================================
- Hits         7998     7296     -702     
- Misses       1597     2188     +591     
- Partials      509      626     +117     
Flag Coverage Δ
integration-test 55.24% <68.75%> (-0.30%) ⬇️
k8s-integration-test 59.11% <75.00%> (-0.24%) ⬇️
oats-test 36.16% <26.44%> (+0.63%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent!

@mariomac mariomac merged commit 521e33f into grafana:main Jun 17, 2024
8 checks passed
@mariomac mariomac deleted the rm-histograms branch June 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants