Helm chart #642

khushijain21 · 2024-02-23T15:13:43Z

Helm Chart for Beyla

test

first draft

Signed-off-by: Syed Nihal <[email protected]>

chart.yaml

adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]>

Signed-off-by: Syed Nihal <[email protected]>

… variable (grafana#635)

Co-authored-by: MattFrick <[email protected]>

Helm 102 - Configmap and env value for external secret

deployments/helm/values.yaml

add readme

…-chart

mariomac · 2024-03-26T11:11:40Z

Mostly LGTM. @arramos84 do you think is worth merging this PR as a starting point for the consolidation with your chart, or it's better to wait?

arramos84 · 2024-03-26T14:42:40Z

Mostly LGTM. @arramos84 do you think is worth merging this PR as a starting point for the consolidation with your chart, or it's better to wait?

@mariomac, this chart has errors out of the box. At a minimum, it should work with the default values. One error (among others) when deploying is a nil pointer since no default ingress values are defined.

…-chart

khushijain21 · 2024-03-26T15:16:23Z

@arramos84 you are right, we forgot to remove all of ingress related code. Changed now!

mariomac · 2024-03-26T15:43:17Z

deployments/helm/values.yaml

+  #   open_port: 8443
+  #   routes:
+  #     unmatched: heuristic
+  #   log_level: info
+  #   otel_traces_export:
+  #     endpoint: http://grafana-agent:4318
+  #  ## or alternatively use
+  #   # grafana:
+  #   #   otlp:
+  #   #     cloud_zone: prod-eu-west-0
+  #   #     cloud_instance_id: 123456  
+  #   #     cloud_api_key:  
+  #   discovery:
+  #     services:
+  #       - k8s_namespace: default
+  #   attributes:
+  #     kubernetes:
+  #       enable: true
+  # internal metrics reporting. Refer: https://grafana.com/docs/beyla/latest/configure/options/#internal-metrics-reporter
+  # If set, user can expose the metrics endpoint via k8s service by configuring .Values.service section
+  #prometheus_export:
+    #port: 9090
+    #path: /metrics


@arramos84

At a minimum, it should work with the default values.

That's an interesting point. Beyla requires at least two input values: the service to instrument and the way to export the data (e.g. the OpenTelemetry endpoint or the Prometheus exporter pod).

So I guess that, to let Beyla work with some default inputs, we should provide something like:

# look for ALL the services in the host discovery: services: - k8s_namespace: . # export metrics as prometheus metrics by default prometheus_export: port: 9090 # enable kubernetes attributes: kubernetes: enable: true

Could we set the above YAML as the default configMapData?

deployments/helm/values.yaml

Signed-off-by: Syed Nihal <[email protected]>

wasim-nihal · 2024-03-28T11:13:28Z

@mariomac , @petewall , I have addressed the commented in the latest commit.

Changes include:

Having default configurations to look for all services.

# look for ALL the services in the host
discovery:
  services:
    - k8s_namespace: .
# export metrics as prometheus metrics by default
prometheus_export:
  port: 9090
# enable kubernetes
attributes:
  kubernetes:
    enable: true

change the values.yaml format for config as below

config:
 create: true
 name: "" # Empty means use the release name, otherwise use this to point to an existing configmap
 data:
   <yaml formatted default data>

Aligning image tags rendering similar grafana agent chart.
Updated Readme
Few other corrections and refactoring

petewall · 2024-03-28T14:16:11Z

deployments/helm/templates/configmap.yaml

@@ -0,0 +1,19 @@
+{{- if and (not .Values.config.create) (eq .Values.config.name "") }}
+  {{- fail "if .Values.config.name is not set, then .Values.config.create should be set to true to use default configuration" }}


grcevski

LGTM! This looks very good now. I think we can merge unless there are any objections and we should be able to build tests with this.

codecov-commenter · 2024-04-04T18:41:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (58a6a7f) to head (6c266ea).
Report is 10 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #642       +/-   ##
===========================================
- Coverage   76.04%   37.94%   -38.10%     
===========================================
  Files         102      102               
  Lines        8165     8172        +7     
===========================================
- Hits         6209     3101     -3108     
- Misses       1614     4890     +3276     
+ Partials      342      181      -161

Flag	Coverage Δ
integration-test	`?`
unittests	`37.94% <ø> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mariomac · 2024-04-05T07:33:31Z

I think that, before merging, some of the contributors still need to agree the license/cla:

@khushijain21 @wasim-nihal

Thanks!

khushijain21 · 2024-04-05T07:44:20Z

@mariomac yes, just signed it

mariomac · 2024-04-05T07:53:31Z

Ok! Then let's merge the PR. If someone sees any issue we can address it in another PR.

@khushijain21 @wasim-nihal thank you a lot for your contribution and your patience!

khushijain21 and others added 30 commits February 22, 2024 14:08

test

82976cc

Merge pull request #1 from nokia/helm-102

557efec

test

chart.yaml

9a58581

service-account

5b3c576

after helm create

7a2e0e2

Merge pull request #2 from nokia/helm-102

e62e38d

first draft

adding rbac with changes for labels and annotations

5e987ff

Signed-off-by: Syed Nihal <[email protected]>

adding rbac with changes for labels and annotations

b9f1558

Signed-off-by: Syed Nihal <[email protected]>

adding rbac with changes for labels and annotations

97ed5bc

Signed-off-by: Syed Nihal <[email protected]>

adding rbac with changes for labels and annotations

5666264

Signed-off-by: Syed Nihal <[email protected]>

test

7ba9686

chart.yaml

service-account

632f31c

adding rbac with changes for labels and annotations

d032b98

Signed-off-by: Syed Nihal <[email protected]>

Replace BEYLA_OTEL_USE_EXPONENTIAL_HISTOGRAMS by standard environment…

f75ac95

… variable (grafana#635)

Automatic update of offsets.json (grafana#639)

32223dc

Co-authored-by: MattFrick <[email protected]>

Fix missing go_trace_map cleanup (grafana#638)

a901739

Merge branch 'grafana:main' into helm-chart

e037188

add release namespace

4fa2007

Update cluster-role.yaml

1b26750

Update cluster-role-binding.yaml

8e7bf8b

values.yaml

b1332f6

configmap and env

d9f0ac9

secret ref

5c5cace

values.yaml

5f864ac

Update configmap.yaml

b2879a6

Update configmap.yaml

ca8621c

Update values.yaml

e9ec4ab

Update configmap.yaml

2d05fc2

Merge pull request #6 from nokia/helm-102

7c05f61

Helm 102 - Configmap and env value for external secret

mariomac reviewed Mar 14, 2024

View reviewed changes

deployments/helm/values.yaml Outdated Show resolved Hide resolved

mariomac reviewed Mar 14, 2024

View reviewed changes

deployments/helm/values.yaml Outdated Show resolved Hide resolved

khushijain21 and others added 9 commits March 17, 2024 13:01

Delete deployments/helm/templates/NOTES.txt

de676a6

add readme

c19a0d0

Merge pull request #10 from nokia/helm-102

6ec975c

add readme

Merge branch 'helm-chart' of https://github.com/nokia/beyla into helm…

700dc1e

…-chart

remove autoscaling

cd6561b

remove autoscaling

94a5043

Merge branch 'helm-chart' of https://github.com/nokia/beyla into helm…

0a675fb

…-chart

remove ingress, update configmap

2968217

Merge branch 'grafana:main' into helm-chart

cf90a9d

khushijain21 requested review from petewall and mariomac March 26, 2024 06:29

khusjain added 2 commits March 26, 2024 20:44

remove all ingress changes

0fe26ea

Merge branch 'helm-chart' of https://github.com/nokia/beyla into helm…

b35d7b2

…-chart

mariomac reviewed Mar 26, 2024

View reviewed changes

petewall reviewed Mar 26, 2024

View reviewed changes

deployments/helm/values.yaml Outdated Show resolved Hide resolved

deployments/helm/values.yaml Outdated Show resolved Hide resolved

wasim-nihal added 2 commits March 28, 2024 13:38

Merge branch 'main' of github.com:grafana/beyla into helm-chart

785c8f2

addressed review comments

6c266ea

Signed-off-by: Syed Nihal <[email protected]>

petewall reviewed Mar 28, 2024

View reviewed changes

grcevski approved these changes Apr 4, 2024

View reviewed changes

mariomac merged commit 763995b into grafana:main Apr 5, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm chart #642

Helm chart #642

khushijain21 commented Feb 23, 2024

mariomac commented Mar 26, 2024 •

edited

Loading

arramos84 commented Mar 26, 2024

khushijain21 commented Mar 26, 2024

mariomac Mar 26, 2024

wasim-nihal commented Mar 28, 2024

petewall Mar 28, 2024

grcevski left a comment

codecov-commenter commented Apr 4, 2024

mariomac commented Apr 5, 2024

khushijain21 commented Apr 5, 2024

mariomac commented Apr 5, 2024

		@@ -0,0 +1,19 @@
		{{- if and (not .Values.config.create) (eq .Values.config.name "") }}
		{{- fail "if .Values.config.name is not set, then .Values.config.create should be set to true to use default configuration" }}

Helm chart #642

Helm chart #642

Conversation

khushijain21 commented Feb 23, 2024

mariomac commented Mar 26, 2024 • edited Loading

arramos84 commented Mar 26, 2024

khushijain21 commented Mar 26, 2024

mariomac Mar 26, 2024

Choose a reason for hiding this comment

wasim-nihal commented Mar 28, 2024

petewall Mar 28, 2024

Choose a reason for hiding this comment

grcevski left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 4, 2024

Codecov Report

mariomac commented Apr 5, 2024

khushijain21 commented Apr 5, 2024

mariomac commented Apr 5, 2024

mariomac commented Mar 26, 2024 •

edited

Loading