Fix missing go_trace_map cleanup #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 78.95% 78.92% -0.04%
==========================================
Files 89 89
Lines 7474 7486 +12
==========================================
+ Hits 5901 5908 +7
- Misses 1252 1256 +4
- Partials 321 322 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
approved these changes
Feb 22, 2024
khushijain21
pushed a commit
to nokia/beyla
that referenced
this pull request
Feb 23, 2024
mariomac
added a commit
that referenced
this pull request
Apr 5, 2024
* test * chart.yaml * service-account * after helm create * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * test chart.yaml * service-account * after helm create adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <[email protected]> * Replace BEYLA_OTEL_USE_EXPONENTIAL_HISTOGRAMS by standard environment variable (#635) * Automatic update of offsets.json (#639) Co-authored-by: MattFrick <[email protected]> * Fix missing go_trace_map cleanup (#638) * add release namespace * Update cluster-role.yaml * Update cluster-role-binding.yaml * values.yaml * configmap and env * secret ref * values.yaml * Update configmap.yaml * Update configmap.yaml * Update values.yaml * Update configmap.yaml * values.yaml * configmap and daemonset changes * 101 * changed existing configmap * clusterolebinding * Update cluster-role-binding.yaml * added comments for external configmap * adding k8s service in helm chart to expose internal beyla metrics. Signed-off-by: Syed Nihal <[email protected]> * affinity, updatestrategy, tolerations ... * Update values.yaml * Delete deployments/helm/templates/tests/test-connection.yaml * Update values.yaml * Update values.yaml * Delete deployments/helm/templates/NOTES.txt * add readme * remove autoscaling * remove autoscaling * remove ingress, update configmap * remove all ingress changes * addressed review comments Signed-off-by: Syed Nihal <[email protected]> --------- Signed-off-by: Syed Nihal <[email protected]> Co-authored-by: Syed Nihal <[email protected]> Co-authored-by: Mario Macias <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: MattFrick <[email protected]> Co-authored-by: Nikola Grcevski <[email protected]> Co-authored-by: Nihal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't cleanup the go_trace_map on server request termination, which might cause a wrong traceparent to be used if the goroutine wasn't parked.