Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Grafana cloud credentials by standard OTLP credentials in quickstart guides #538

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

mariomac
Copy link
Contributor

Addresses comment: #530 (review)

Copy link
Contributor

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariomac thanks Mario, I made edits to cpp.md with suggestions. If you agree with those you can copy over relevant parts to the others.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bcd95f) 80.06% compared to head (7c9fdb2) 67.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #538       +/-   ##
===========================================
- Coverage   80.06%   67.94%   -12.12%     
===========================================
  Files          69       66        -3     
  Lines        5778     5662      -116     
===========================================
- Hits         4626     3847      -779     
- Misses        930     1528      +598     
- Partials      222      287       +65     
Flag Coverage Δ
integration-test 67.94% <ø> (-0.85%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac
Copy link
Contributor Author

mariomac commented Jan 10, 2024

@grafsean thank you for the edits! Applied them to the rest of languages.

@grafsean grafsean merged commit ce300c5 into grafana:main Jan 11, 2024
5 checks passed
@mariomac mariomac deleted the quickstart-fixes branch January 11, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants