First draft for Go quickstart guide #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
===========================================
- Coverage 79.36% 45.22% -34.15%
===========================================
Files 69 67 -2
Lines 5772 5597 -175
===========================================
- Hits 4581 2531 -2050
- Misses 970 2914 +1944
+ Partials 221 152 -69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zeitlinger
reviewed
Jan 10, 2024
| ```sh | ||
| export OTEL_EXPORTER_OTLP_ENDPOINT=https://otlp-gateway-prod-eu-west-0.grafana.net/otlp | ||
| export GRAFANA_CLOUD_INSTANCE_ID=123456 | ||
| export GRAFANA_CLOUD_API_KEY="your api key here..." |
There was a problem hiding this comment.
- we should not use API keys any more, since they are deprecated
- the setup is easier if you use the new otel tile, which generate both the endpoint and headers
|
@mariomac in the future would it be possible to complete a technical writing review before merging? |
|
@grafsean sure! Sorry for merging it too early |
|
@mariomac thank you 😄 not a problem! I'll share feedback in a new PR. In the meantime could we address Gregor's comment about API keys #530 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.