Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: reducing scope of informer #1245

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

mariomac
Copy link
Contributor

Reverts this PR #1210

We did the wrong assumption that global entities were only required for Network Metrics. But service graph metrics also require being decorated from cluster-wide pods.

Since we are working on a definitive solution based on external informers caches, I'm just reverting this change to avoid bugs and simplifying the code.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (8c3c9db) to head (27ca29f).

Files with missing lines Patch % Lines
pkg/internal/kube/informer_provider.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   81.89%   81.95%   +0.05%     
==========================================
  Files         137      137              
  Lines       11489    11470      -19     
==========================================
- Hits         9409     9400       -9     
+ Misses       1544     1541       -3     
+ Partials      536      529       -7     
Flag Coverage Δ
integration-test 60.98% <50.00%> (-0.04%) ⬇️
k8s-integration-test 58.80% <90.00%> (+0.30%) ⬆️
oats-test 36.47% <50.00%> (+0.04%) ⬆️
unittests 53.16% <90.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc
Copy link
Contributor

marctc commented Oct 10, 2024

But service graph metrics also require being decorated from cluster-wide pods.

Oh shoot! Agree on having one solution for this problem.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 392baa8 into grafana:main Oct 11, 2024
10 checks passed
@mariomac mariomac deleted the revert-informer branch October 11, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants