Use only the required informers #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 81.88% 81.68% -0.21%
==========================================
Files 137 137
Lines 11450 11475 +25
==========================================
- Hits 9376 9373 -3
- Misses 1543 1562 +19
- Partials 531 540 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
reviewed
Oct 1, 2024
pkg/internal/kube/informer.go
Outdated
| informerFactory = informers.NewSharedInformerFactory(client, resyncTime) | ||
| } else { | ||
| fieldSelector := fields.OneTermEqualSelector("spec.nodeName", restrictNode).String() | ||
| k.log.Info("using field selector", "selector", fieldSelector) |
There was a problem hiding this comment.
do we want to keep that as info? or debug would be better?
There was a problem hiding this comment.
you are right. Moving to debug would have more sense
marctc
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of Marc's PR: https://github.com/grafana/beyla/pull/1209/files
It would narrow the scope of the informers:
Addresses #1198 and #824