Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gallery preview overlay and backdrop #7505

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Conversation

MMP0
Copy link
Contributor

@MMP0 MMP0 commented Feb 21, 2024

Fixes: #5971

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 21, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/c82cd0164dc484750422e5117dbb46e249851720/gradio-4.19.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@c82cd0164dc484750422e5117dbb46e249851720#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 21, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app patch
@gradio/gallery patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Gallery preview overlay and backdrop

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Feb 22, 2024
@dawoodkhan82 dawoodkhan82 self-requested a review February 22, 2024 18:06
Copy link
Collaborator

@dawoodkhan82 dawoodkhan82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and fixes the issues. Thanks @MMP0!

@abidlabs abidlabs merged commit b186767 into gradio-app:main Feb 22, 2024
8 checks passed
@MMP0 MMP0 deleted the gallery-fix branch February 22, 2024 19:34
@pngwn pngwn mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery full images are not shown correctly on Firefox
4 participants