Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery full images are not shown correctly on Firefox #5971

Closed
1 task done
AndrewMead10 opened this issue Oct 18, 2023 · 8 comments · Fixed by #7505
Closed
1 task done

Gallery full images are not shown correctly on Firefox #5971

AndrewMead10 opened this issue Oct 18, 2023 · 8 comments · Fixed by #7505
Labels
bug Something isn't working

Comments

@AndrewMead10
Copy link

Describe the bug

When selecting an image from a gallery, the image is not centered, and the other images behind it are not hidden either, as seen on the demo galleries in the documentation.
Selection_001

Have you searched existing issues? 🔎

  • I have searched and found no existing issues

Reproduction

Both exmaples on the doc page for gallery https://www.gradio.app/docs/gallery

Screenshot

No response

Logs

No response

System Info

latest version/ version on the website

Severity

I can work around it

@AndrewMead10 AndrewMead10 added the bug Something isn't working label Oct 18, 2023
@hannahblair
Copy link
Collaborator

hannahblair commented Oct 18, 2023

Hi @AndrewMead10! Strange - the images are working fine for me on the website right now. Can I ask what system and browser you're using?

Screenshot 2023-10-18 at 10 19 16

@hannahblair hannahblair added the needs repro Awaiting full reproduction label Oct 18, 2023
@AndrewMead10
Copy link
Author

Ubuntu 22 and firefox

@kkuczkowska
Copy link

I have a similar problem working on Ubuntu 22 and Firefox. With my demo working locally, preview of gallery picture is small and on the left, not centered, as shown on screenshot below.
image

When sharing my demo (still running from my local Ubuntu), I had a client running it on Windows using Opera and preview was working correctly - meaning the previewed image was big and centered, as shown below.

image

@abidlabs abidlabs removed the needs repro Awaiting full reproduction label Nov 2, 2023
@Harryoung
Copy link

I meet the same problem on windows! Is there a solution? 🥲

@pink-red
Copy link

pink-red commented Jan 18, 2024

Reproduction

Both exmaples on the doc page for gallery https://www.gradio.app/docs/gallery

I have the same problem on Arch Linux in Firefox 121.0.1, both with the latest version of Gradio (4.14.0) installed locally and with the doc page. The problem wasn't present previously. For example, on version 3.44.3 Gallery worked correctly.

Severity

I can work around it

@AndrewMead10, could you please share the workaround?

@pink-red
Copy link

pink-red commented Jan 18, 2024

In fact, 3.50.2 is the last version without the bug. It is present in 4.0.0.

Edit: I stand corrected, the bug is present in 3.50.2. It seems that some images are okay, while others have problems, depending on the size and aspect ratio.

Edit 2: Bisected a bit more. The last working version is 3.44.4. The bug first appeared in 3.45.0.

@AndrewMead10
Copy link
Author

@AndrewMead10, could you please share the workaround?

I just ended up using windows, no easy fix i could find for linux

@pink-red
Copy link

Found a simple workaround:

with gr.Blocks(css=".preview { width: 100%; }") as demo:
    ...

@abidlabs abidlabs changed the title Gallery full images are not shown correctly Gallery full images are not shown correctly on Firefox Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants