Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a section on security #3408

Merged
merged 6 commits into from
Mar 7, 2023
Merged

Added a section on security #3408

merged 6 commits into from
Mar 7, 2023

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Mar 7, 2023

Closes: #3397

@abidlabs abidlabs requested a review from aliabd March 7, 2023 19:16
@gradio-pr-bot
Copy link
Collaborator

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3408-all-demos

Copy link
Collaborator

@aliabd aliabd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes

@@ -10,6 +10,7 @@ How to share your Gradio app:
6. [Adding authentication to the page](#authentication)
7. [Accessing Network Requests](#accessing-the-network-request-directly)
8. [Mounting within FastAPI](#mounting-within-another-fastapi-app)
9. [Security](#security)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a valid link

[Security](#security)

[Security](#security-and-file-access)


In particular, Gradio apps grant users access to three kinds of files:

* files in the same folder (or a subdirectory) of where the Gradio script is launched from. For example, if the path to your gradio scripts is `/home/usr/scripts/project/app.py` and you launch it from `/home/usr/scripts/project/`, then users of your shared Gradio app will be able to access any files inside `/home/usr/scripts/project/`. This is needed so that you can easily reference these files in your Gradio app.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize first word in these bullet points

@abidlabs
Copy link
Member Author

abidlabs commented Mar 7, 2023

Thank you @aliabd! Agree with the changes

@abidlabs abidlabs merged commit 2fd9b55 into main Mar 7, 2023
@abidlabs abidlabs deleted the security branch March 7, 2023 22:21
dawoodkhan82 pushed a commit that referenced this pull request Mar 8, 2023
* security

* added section on security

* security

* changes from review
dawoodkhan82 added a commit that referenced this pull request Mar 9, 2023
* hub telemetry

* more analytics

* format

* changelog

* Gradio Status Page  (#3331)

* add status page to error message

* changelog

* link to status page on website

* move link to the right

* merge

* merge

* Add option to display gallery in preview mode (#3345)

* Add code + api

* CHANGELOG

* dropdown (#3338)

* fix

* fixes

* format

* changelog

* Update gradio/components.py

Co-authored-by: Abubakar Abid <[email protected]>

* fix clear case

---------

Co-authored-by: Abubakar Abid <[email protected]>

* Some improvements to Flag (#3289)

* Fixes to button disable

* button

* formatting

* flagging fix

* fixes

* formatter

* changelog

* ormatting

* tests

* saving

* adding optionality for flagging

* updatest

* error catching

* updates

* changelog

* tests

* typing

* flag button

* formatting

* tests

* tests

* tests

* increased latency

* queue fix

* clear

* formatting

* fix

* fix tests

* Fix flaky external test (#3348)

* Fix flaky external test

* CHANGELOG

* Undo accidental diff

* Fix flaky external test

* CHANGELOG

* Undo accidental diff

* Remove from changelog

* Use bunny file

---------

Co-authored-by: Abubakar Abid <[email protected]>

* updates

* format

* more updates

* threading

* fixes

* Fix error when using backen_fn and custom js at the same time (#3358)

* Fix error when using backen_fn and custom js at the same time

* generate notebooks

* update changelog

* changes

---------

Co-authored-by: Ali Abid <[email protected]>
Co-authored-by: Freddy Boulton <[email protected]>

* Fix File updating (#3375)

* Fix

* Remove line

* Add unit test

* CHANGELOG

* Remove comment

* Updated chat ui (#3370)

* test

* changes

* chagnes

* changes

* changes

* changes

* changes

* Update CHANGELOG.md

* changes

* Update demo/chatbot_multimodal/run.py

Co-authored-by: Abubakar Abid <[email protected]>

* Update demo/chatbot_simple_demo/run.py

Co-authored-by: Abubakar Abid <[email protected]>

* changes

* changes

* changes

---------

Co-authored-by: Abubakar Abid <[email protected]>

* fixes

* New Version Docs (#3376)

* [create-pull-request] automated change

* empty commit

* [create-pull-request] automated change

* empty commit

---------

Co-authored-by: abidlabs <[email protected]>
Co-authored-by: aliabd <[email protected]>

* requirements

* test requirements

* Release 3.20.1 (#3390)

* release 3.20.1

* changelog

* merge

* New Version Docs (#3392)

* [create-pull-request] automated change

* trigger ci

---------

Co-authored-by: abidlabs <[email protected]>
Co-authored-by: Abubakar Abid <[email protected]>

* merge

* Remove everything related to encryption (#3396)

* remove requirements

* deprecate encrypt

* remove flagging

* deprecate

* formatting

* lint

* Adds a Chinese translation for the `README` (#3394)

* add chinese readme

* add chinese readme

* update changelog

* fix render_readme and english readme

* generate readme

* remove template and quickstart files

* link to chinese from english

* fix assets paths

* link to english from chinese

* change file location

* fix link

* fix link

* fix link

---------

Co-authored-by: aliabd <[email protected]>

* fix bad codeblock (#3401)

* Always set queue=False if every is None for load events (#3391)

* Always set queue=False if every is None

* CHANGELOG + linting

* Move to latest release section

* changelog

---------

Co-authored-by: Abubakar Abid <[email protected]>

* JS client take 2 (#3388)

* start

* change api

* integrate into gradio

* log

* try this

* format

* changes

* format

* fix css

* fix file

* fix #3282 avoid in-place dict updates (#3405)

* fix #3282 avoid in-place dict updates

* add tests and changelog for PR3405

* Fix markdown embedded component in docs (#3410)

* revert to old md component demo

* changelog

* Added a section on security (#3408)

* security

* added section on security

* security

* changes from review

* Fix local tests (#3411)

* document embed params

* fix tests

* cleanup

* cleanup

* cleanup

* revert

* changelog

* Document web component parameters (#3407)

* document embed params

* changelog

* iframe

* fixed review changes

* requirements

* fixes

* format

* format

* requirements

---------

Co-authored-by: Abubakar Abid <[email protected]>
Co-authored-by: Ali Abdalla <[email protected]>
Co-authored-by: Freddy Boulton <[email protected]>
Co-authored-by: pngwn <[email protected]>
Co-authored-by: Jialei <[email protected]>
Co-authored-by: Ali Abid <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: abidlabs <[email protected]>
Co-authored-by: Uanu <[email protected]>
Co-authored-by: gitgithan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a section on security in the docs
3 participants