-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to display gallery in preview mode #3345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3345-all-demos |
pngwn
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @freddyaboulton!
freddyaboulton
force-pushed
the
3311-display-gallery-in-preview-mode
branch
from
February 28, 2023 17:28
cd8417b
to
6d7cc20
Compare
Thank you for the review @pngwn ! 🐧 |
dawoodkhan82
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Add code + api * CHANGELOG
dawoodkhan82
added a commit
that referenced
this pull request
Mar 9, 2023
* hub telemetry * more analytics * format * changelog * Gradio Status Page (#3331) * add status page to error message * changelog * link to status page on website * move link to the right * merge * merge * Add option to display gallery in preview mode (#3345) * Add code + api * CHANGELOG * dropdown (#3338) * fix * fixes * format * changelog * Update gradio/components.py Co-authored-by: Abubakar Abid <[email protected]> * fix clear case --------- Co-authored-by: Abubakar Abid <[email protected]> * Some improvements to Flag (#3289) * Fixes to button disable * button * formatting * flagging fix * fixes * formatter * changelog * ormatting * tests * saving * adding optionality for flagging * updatest * error catching * updates * changelog * tests * typing * flag button * formatting * tests * tests * tests * increased latency * queue fix * clear * formatting * fix * fix tests * Fix flaky external test (#3348) * Fix flaky external test * CHANGELOG * Undo accidental diff * Fix flaky external test * CHANGELOG * Undo accidental diff * Remove from changelog * Use bunny file --------- Co-authored-by: Abubakar Abid <[email protected]> * updates * format * more updates * threading * fixes * Fix error when using backen_fn and custom js at the same time (#3358) * Fix error when using backen_fn and custom js at the same time * generate notebooks * update changelog * changes --------- Co-authored-by: Ali Abid <[email protected]> Co-authored-by: Freddy Boulton <[email protected]> * Fix File updating (#3375) * Fix * Remove line * Add unit test * CHANGELOG * Remove comment * Updated chat ui (#3370) * test * changes * chagnes * changes * changes * changes * changes * Update CHANGELOG.md * changes * Update demo/chatbot_multimodal/run.py Co-authored-by: Abubakar Abid <[email protected]> * Update demo/chatbot_simple_demo/run.py Co-authored-by: Abubakar Abid <[email protected]> * changes * changes * changes --------- Co-authored-by: Abubakar Abid <[email protected]> * fixes * New Version Docs (#3376) * [create-pull-request] automated change * empty commit * [create-pull-request] automated change * empty commit --------- Co-authored-by: abidlabs <[email protected]> Co-authored-by: aliabd <[email protected]> * requirements * test requirements * Release 3.20.1 (#3390) * release 3.20.1 * changelog * merge * New Version Docs (#3392) * [create-pull-request] automated change * trigger ci --------- Co-authored-by: abidlabs <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> * merge * Remove everything related to encryption (#3396) * remove requirements * deprecate encrypt * remove flagging * deprecate * formatting * lint * Adds a Chinese translation for the `README` (#3394) * add chinese readme * add chinese readme * update changelog * fix render_readme and english readme * generate readme * remove template and quickstart files * link to chinese from english * fix assets paths * link to english from chinese * change file location * fix link * fix link * fix link --------- Co-authored-by: aliabd <[email protected]> * fix bad codeblock (#3401) * Always set queue=False if every is None for load events (#3391) * Always set queue=False if every is None * CHANGELOG + linting * Move to latest release section * changelog --------- Co-authored-by: Abubakar Abid <[email protected]> * JS client take 2 (#3388) * start * change api * integrate into gradio * log * try this * format * changes * format * fix css * fix file * fix #3282 avoid in-place dict updates (#3405) * fix #3282 avoid in-place dict updates * add tests and changelog for PR3405 * Fix markdown embedded component in docs (#3410) * revert to old md component demo * changelog * Added a section on security (#3408) * security * added section on security * security * changes from review * Fix local tests (#3411) * document embed params * fix tests * cleanup * cleanup * cleanup * revert * changelog * Document web component parameters (#3407) * document embed params * changelog * iframe * fixed review changes * requirements * fixes * format * format * requirements --------- Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: Ali Abdalla <[email protected]> Co-authored-by: Freddy Boulton <[email protected]> Co-authored-by: pngwn <[email protected]> Co-authored-by: Jialei <[email protected]> Co-authored-by: Ali Abid <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: abidlabs <[email protected]> Co-authored-by: Uanu <[email protected]> Co-authored-by: gitgithan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3311
style=True
and the gallery is in a "Cleared State", i.e. value is [] or None, then the next update should display the gallery in preview mode.To test,
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.