Adding in support for s390x and ppc64le #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks great! Do you have CircleCI enabled on your fork on this repo? I noticed there are no CI status checks showing up on this PR, and I think that commonly happens when CircleCI is enabled on the fork. Not sure of any other way to fix it than to disable it. Could you share a link to the build that ran when you pushed this branch? |
|
@dnephin I linked to my branch in my comment above, but here is the link again: https://app.circleci.com/pipelines/github/james-crowley/gotestsum/2/workflows/a72c6864-82b7-43d8-b920-2c2489a6ea75/jobs/11
You are spot on. I had it enabled on my fork to verify if the build would work. This is an known issues, see point number 2 in this support article: https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- This should be fixed in an upcoming feature from CircleCI! I would love to get this merged asap and get a new version of |
dnephin
approved these changes
Aug 10, 2022
kevinrobayna
added a commit
to kevinrobayna/goprod
that referenced
this pull request
Aug 22, 2022
Bumps gotest.tools/gotestsum from 1.7.0 to 1.8.2. Release notes Sourced from gotest.tools/gotestsum's releases. v1.8.2 What's Changed Show shuffle seed by @dnephin in gotestyourself/gotestsum#256 Update tests, and cleanup formats by @dnephin in gotestyourself/gotestsum#262 Remove one dependency, update the rest by @dnephin in gotestyourself/gotestsum#263 Test against go1.19, remove go1.15 by @dnephin in gotestyourself/gotestsum#269 Add project name to junit.xml output by @nikolaigut in gotestyourself/gotestsum#261 Adding in support for s390x and ppc64le by @james-crowley in gotestyourself/gotestsum#270 New Contributors @nikolaigut made their first contribution in gotestyourself/gotestsum#261 @james-crowley made their first contribution in gotestyourself/gotestsum#270 Full Changelog: gotestyourself/[email protected] v1.8.1 Changelog e209ec9 Merge pull request #249 from dnephin/add-update-flag 849289b Add to readme 57ba68e Add some tests for watch events 14592d7 watch: add u key for updates f1fdcbd Merge pull request #246 from dnephin/warn-watch-and-paths ddb4125 Document --watch with extra package paths 938480e Merge pull request #245 from dnephin/aix 6b46741 Fix the build on aix v1.8.0 Changelog 69fcbcb Merge pull request #243 from dnephin/enable-color-on-github-actions 9e8433c Enable color by default when run from github actions a8b4e27 Merge pull request #242 from gotestyourself/docs-post-run 4cc96fb Improve the docs for --post-run-command cc0c1a1 Merge pull request #234 from uhthomas/exec-stdin ac4bc6f Improve the test for input from stdin ce158b4 Pass stdin to go test 0fa88f3 Merge pull request #241 from gotestyourself/mkdir-path d93af71 create any missing directories for {json,junit}file 528a3fd Merge pull request #235 from ashanbrown/asb/ignore-warnings bba51ac Fix e2e test failure 90a5a10 Ensure we still rerun tests when there are warnings d9cd222 Merge pull request #237 from gotestyourself/ci-go1.18 99a7f30 fix goreleaser afec7a6 ci: go1.18 661b091 Merge pull request #226 from g-gaston/compile-test2json-without-go 42e50c2 Add instructions to compile test2json without the need of a local go installation 08a7689 Merge pull request #224 from greut/fix/golangci-lint 2a49979 fix: remove deprecated linters from golanci-lint 87d6387 Merge pull request #223 from dmitris/patch-1 98a1847 update 'go get' idirective to 'go install' e5de87c Merge pull request #216 from dnephin/pkg-elapsed ... (truncated) Commits f863151 Merge pull request #270 from james-crowley/alt_arch_support 85a7f9e feat: Adding in support for s390x and ppc64le 9fea242 Merge pull request #261 from nikolaigut/main 20f51e0 Add project name option for junit xml de44b55 Merge pull request #267 from dnephin/update-readme c54abf9 Set golangci-lint config path in CI 5a46af5 Demo image url 9bab80b .project directory e8ca43d Consolidate 9abe001 Move log to internal Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Robayna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in support for
s390xandppc64leon Linux.In my testing I was able to see a successful build on CircleCI linked here. This build allowed me to pull down the
s390xartifact from CircleCI to validate a successful build.Closes #268
@dnephin Let me know if you need anything else for this PR to be merged. Happy to help!