Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests, and cleanup formats #262

Merged
merged 11 commits into from
Jul 16, 2022
Merged

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Jul 16, 2022

Update golden files used to store go test -json inputs, and update the tests to use the new input. Remove some dependencies and modernize the tests.

  • use a new go-test-json for input that includes all the latest stubpkg output
  • organize testdata files into directories input/ for inputs, format/ for expect output of formats, and summary/ for expected output of summary
  • use t.Cleanup
  • use table tests

dnephin added 11 commits July 16, 2022 16:28
Use t.Cleanup and remove clockwork dependency.
The file is not really useful anymore because we don't want to
regenerate all the files at once.

Document how to generate files instead.
Move testdata into input/ and summary/ directories
Use a test table
Use the new input data
Organize outputs into format/
And add a couple more test cases
@dnephin dnephin merged commit 683cc97 into gotestyourself:main Jul 16, 2022
@dnephin dnephin deleted the cleanup-formats branch July 16, 2022 21:53
kevinrobayna added a commit to kevinrobayna/goprod that referenced this pull request Aug 22, 2022
Bumps gotest.tools/gotestsum from 1.7.0 to 1.8.2.

Release notes
Sourced from gotest.tools/gotestsum's releases.

v1.8.2
What's Changed

Show shuffle seed by @​dnephin in gotestyourself/gotestsum#256
Update tests, and cleanup formats by @​dnephin in gotestyourself/gotestsum#262
Remove one dependency, update the rest by @​dnephin in gotestyourself/gotestsum#263
Test against go1.19, remove go1.15 by @​dnephin in gotestyourself/gotestsum#269
Add project name to junit.xml output by @​nikolaigut in gotestyourself/gotestsum#261
Adding in support for s390x and ppc64le by @​james-crowley in gotestyourself/gotestsum#270

New Contributors

@​nikolaigut made their first contribution in gotestyourself/gotestsum#261
@​james-crowley made their first contribution in gotestyourself/gotestsum#270

Full Changelog: gotestyourself/[email protected]
v1.8.1
Changelog

e209ec9 Merge pull request #249 from dnephin/add-update-flag
849289b Add to readme
57ba68e Add some tests for watch events
14592d7 watch: add u key for updates
f1fdcbd Merge pull request #246 from dnephin/warn-watch-and-paths
ddb4125 Document --watch with extra package paths
938480e Merge pull request #245 from dnephin/aix
6b46741 Fix the build on aix

v1.8.0
Changelog

69fcbcb Merge pull request #243 from dnephin/enable-color-on-github-actions
9e8433c Enable color by default when run from github actions
a8b4e27 Merge pull request #242 from gotestyourself/docs-post-run
4cc96fb Improve the docs for --post-run-command
cc0c1a1 Merge pull request #234 from uhthomas/exec-stdin
ac4bc6f Improve the test for input from stdin
ce158b4 Pass stdin to go test
0fa88f3 Merge pull request #241 from gotestyourself/mkdir-path
d93af71 create any missing directories for {json,junit}file
528a3fd Merge pull request #235 from ashanbrown/asb/ignore-warnings
bba51ac Fix e2e test failure
90a5a10 Ensure we still rerun tests when there are warnings
d9cd222 Merge pull request #237 from gotestyourself/ci-go1.18
99a7f30 fix goreleaser
afec7a6 ci: go1.18
661b091 Merge pull request #226 from g-gaston/compile-test2json-without-go
42e50c2 Add instructions to compile test2json without the need of a local go installation
08a7689 Merge pull request #224 from greut/fix/golangci-lint
2a49979 fix: remove deprecated linters from golanci-lint
87d6387 Merge pull request #223 from dmitris/patch-1
98a1847 update 'go get' idirective to 'go install'
e5de87c Merge pull request #216 from dnephin/pkg-elapsed



... (truncated)


Commits

f863151 Merge pull request #270 from james-crowley/alt_arch_support
85a7f9e feat: Adding in support for s390x and ppc64le
9fea242 Merge pull request #261 from nikolaigut/main
20f51e0 Add project name option for junit xml
de44b55 Merge pull request #267 from dnephin/update-readme
c54abf9 Set golangci-lint config path in CI
5a46af5 Demo image url
9bab80b .project directory
e8ca43d Consolidate
9abe001 Move log to internal
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kevin Robayna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant