Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from uBlock repo #154

Closed
wants to merge 17 commits into from
Closed

Conversation

chrisaljoudi
Copy link
Contributor

Currently includes:

  • Use SVGs for icons instead of webfont (closes Icons are broken with standard font set. #15).
  • setIcon for Chrome and Safari no longer sets both the icon img (expensive) and the badge text every time it's called.
    • IconState keeps track of the state of the icon for a tab.
    • Preliminary Chrome benchmarks suggest 22% less CPU time consumed by updateBadge total.
    • Safari has much more robust toolbar icon rendering overall.
  • Safari support for inline-script blocking.
  • Minor refinements to Safari popup behavior.

@chrisaljoudi chrisaljoudi changed the title Safari: add support for inline-script blocking Fixes from uBlock repo Apr 29, 2015
@chrisaljoudi
Copy link
Contributor Author

@gorhill added some more fixes. Any idea why some of your commits are showing up as part of this pull request?

I rebased on gorhill:master — is that the wrong thing to do?

@gorhill
Copy link
Owner

gorhill commented May 1, 2015

I'm confused here. Why are you pushing fixes here?

I plan to work on this version only as I feel like working on something, I do not plan to support Safari, for the Fontawesome icons I am not sure I want to go the SVG way, etc. etc.

In short, thanks for the thought, but no need to push fixes/changes to here -- you have your plate full enough with the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are broken with standard font set.
2 participants