-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes from uBlock repo #154
Conversation
Gets rid of background page exceptions
@gorhill added some more fixes. Any idea why some of your commits are showing up as part of this pull request? I rebased on |
I'm confused here. Why are you pushing fixes here? I plan to work on this version only as I feel like working on something, I do not plan to support Safari, for the Fontawesome icons I am not sure I want to go the SVG way, etc. etc. In short, thanks for the thought, but no need to push fixes/changes to here -- you have your plate full enough with the main branch. |
Currently includes:
setIcon
for Chrome and Safari no longer sets both the iconimg
(expensive) and the badge text every time it's called.IconState
keeps track of the state of the icon for a tab.updateBadge
total.