Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are broken with standard font set. #15

Closed
louipc opened this issue Apr 11, 2015 · 16 comments
Closed

Icons are broken with standard font set. #15

louipc opened this issue Apr 11, 2015 · 16 comments

Comments

@louipc
Copy link

louipc commented Apr 11, 2015

The issue is already well described here: uBlock-LLC/uBlock#1181
Commits to fix are here: uBlock-LLC/uBlock@a947537...53768af

@BigDaddyLinux
Copy link

Can anybody explain this for the non tech guy. Is this issue going to be fixed in an upcoming release? I do not personally have this issue but a family member does have the broken icons and I have no idea how to fix it.
any help is appreciated.

@gorhill
Copy link
Owner

gorhill commented Apr 17, 2015

The extension's package contains FontAwesome font file, this is used to render various icons used in uBlock. Using a font for icons simplifies a lot maintenance. However the --disable-remote-fonts flag also affects local fonts (not just the remote ones as the name of the flag implies), and this prevents the FontAwesome font file (which is local, part of uBlock package) from being loaded by uBlock, and as a result, no icons in the UI.

@BigDaddyLinux
Copy link

Thank you for the explanation. The only question I have is, Is there something I can do on my end to fix it or do we need to wait for it to be fixed in an upcoming release?

@gorhill
Copy link
Owner

gorhill commented Apr 17, 2015

I don't know of anything else which can be done other than not using --disable-remote-font. I don't plan to release a fix for this in the next release, because that would delay unduly the release to the next week end at earliest. You could install chrisaljoudi/uBlock repo, it has the fix.

@BigDaddyLinux
Copy link

I thank you for your patience in explaining it. I would rather continue using your releases.
Where Is The --disable-remote-font setting? Is that in ublock or in firefox itself?
How do I not use it

@gorhill
Copy link
Owner

gorhill commented Apr 17, 2015

You can toggle the flag in about:config (Firefox), as explained here (with further instructions for Chromium).

@ghost
Copy link

ghost commented Apr 17, 2015

This user style allows the user to only use a font they want while allowing font awesome to work. It requires Stylish of course.

https://userstyles.org/styles/112439/disallow-web-page-fonts-except-fontawesome-et-al

Third party fonts are a potential privacy issue. I'm uncertain if the user style could address this. If the desire to use a specific font is driven by aesthetics then the user style should be a nice work around.

Fanboy's Anti-thirdparty Font list addresses the privacy issue to an extent. Fwiw, IceCat, the GNU version of Firefox is pretty keen on disabling fonts out of the box.

@louipc
Copy link
Author

louipc commented Apr 17, 2015

On Fri 17 Apr 2015 09:42 -0700, FrankNitty wrote:

Thank you for the explanation. The only question I have is, Is there
something I can do on my end to fix it or do we need to wait for it to be
fixed in an upcoming release?

It's patched in the latest beta release of the chrisaljoudi maintained ublock.
https://github.com/chrisaljoudi/uBlock/releases/tag/0.9.3.5-beta.2

@BigDaddyLinux
Copy link

thank you all for your help and your hard work on the addon itself

@chrisaljoudi
Copy link
Contributor

#154 addresses this.

@gorhill
Copy link
Owner

gorhill commented Jun 10, 2015

c

@RoxKilly
Copy link

deleted.
[Just realized I should have opened a new issue. See #359]

@louipc
Copy link
Author

louipc commented Jun 28, 2015

That is a nice feature but it doesn't address the bug.
The interface is still broken when using standard font set.
Is this a won't fix?

@gorhill
Copy link
Owner

gorhill commented Jun 28, 2015

It does fix the bug for people who wanted to disable remote fonts (as reported in the original issue). If your goal is to force web page to use a specific font, I consider this a Firefox issue.

@louipc
Copy link
Author

louipc commented Jun 29, 2015

Not strictly a firefox issue. The interface breaks in chromium as well when launching with --disable-remote-fonts. Would be nice if it didn't break. Please reopen if you're open to solutions/ideas. thanks!

@gorhill
Copy link
Owner

gorhill commented Jun 29, 2015

The interface breaks in chromium as well when launching with --disable-remote-fonts

That's the point of the fix, to not use --disable-remote-fonts and to let uBlock do the blocking of remote fonts instead -- with ability to do it on a per-site basis as an extra.

gorhill pushed a commit that referenced this issue Oct 1, 2016
Updated typo in readme, fixes #14
pmrowla pushed a commit to pmrowla/uBlock that referenced this issue Feb 7, 2017
geoffdutton pushed a commit to geoffdutton/uBlock that referenced this issue Apr 18, 2018
No need to modify the original files anymore
ryanbr added a commit to ryanbr/uBlock that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants