Skip to content
This repository has been archived by the owner on Nov 8, 2019. It is now read-only.

Added a setter to the GvrKeyboard EditorText #814

Closed
wants to merge 1 commit into from

Conversation

vinhui
Copy link

@vinhui vinhui commented Dec 20, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@vinhui
Copy link
Author

vinhui commented Dec 20, 2017

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@vinhui
Copy link
Author

vinhui commented Dec 20, 2017

Signed it now with the correct email

@googlebot
Copy link

CLAs look good, thanks!

@vinhui vinhui mentioned this pull request Dec 20, 2017
@rusmaxham
Copy link
Contributor

Thank you. This change has been accepted and merged into our internal repo and will be released in a future release.

@rusmaxham rusmaxham closed this Jan 9, 2018
@vinhui vinhui mentioned this pull request Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants