Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deny warnings to CI #189

Closed
iffyio opened this issue Feb 10, 2021 · 0 comments · Fixed by #205
Closed

Move deny warnings to CI #189

iffyio opened this issue Feb 10, 2021 · 0 comments · Fixed by #205
Labels
area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break

Comments

@iffyio
Copy link
Collaborator

iffyio commented Feb 10, 2021

https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/

We want to remove the deny warning in code and instead pass an env var to cargo in CI that fails if there are any warnings (RUSTFLAGS=-Dwarnings I think it was this one)
@iffyio iffyio added area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break labels Feb 12, 2021
@markmandel markmandel mentioned this issue Mar 6, 2021
Merged
markmandel added a commit that referenced this issue Mar 6, 2021
@markmandel
Move deny warnings to CI
0198a86 
What is nice about this is that we deny warnings for the stable version
of Rust that we support, and we ignore warnings for the nightly version,
which has more changes more often.

Closes #189
@markmandel markmandel mentioned this issue Mar 6, 2021
Merged
markmandel added a commit that referenced this issue Mar 8, 2021
@markmandel
Move deny warnings to CI (#205)
917976f 
What is nice about this is that we deny warnings for the stable version
of Rust that we support, and we ignore warnings for the nightly version,
which has more changes more often.

Closes #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Development tooling. area/tests Unit tests, integration tests, anything to make sure things don't break
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move deny warnings to CI googleforgames/quilkin
1 participant
@iffyio