Skip to content

Commit

Permalink
Move deny warnings to CI
Browse files Browse the repository at this point in the history
What is nice about this is that we deny warnings for the stable version
of Rust that we support, and we ignore warnings for the nightly version,
which has more changes more often.

Closes #189
  • Loading branch information
markmandel committed Mar 6, 2021
1 parent 9a271fb commit 0198a86
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ steps:
# that it skips checking some files that were built previously. As a result
# we run it before other cargo sub-commands to ensure that it checks all files.
- name: gcr.io/$PROJECT_ID/ci
args: ["clippy", "--tests"]
args: ["clippy", "--tests", "--", "-D", "warnings"]
id: clippy
- name: gcr.io/$PROJECT_ID/ci
args: ["fmt", "--", "--check"]
Expand Down
2 changes: 0 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* limitations under the License.
*/

// Fail the build if clippy finds any warnings.
#![deny(warnings)]
// Running external documentation tests depends on the
// `external_doc` unstable feature only available on a
// nightly compiler. So we enable the feature only when needed.
Expand Down

0 comments on commit 0198a86

Please sign in to comment.