Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reference docs and sync it with Examples dir #970

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Fix Reference docs and sync it with Examples dir #970

merged 1 commit into from
Jul 31, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jul 31, 2019

There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For #969.

@aLekSer aLekSer force-pushed the fix/example-documentation branch from 43b1b1d to ef414b2 Compare July 31, 2019 14:39
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c51152bd-f3df-49ab-8f6a-deea5429008f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/970/head:pr_970 && git checkout pr_970
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-43b1b1d

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 31, 2019

I have made a copy of yaml files as is, because without comments it would be harder to keep them in sync later.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dcba8fdf-0f76-41d6-a24a-e0796ec62207

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 31, 2019 •
edited
Loading

Flaky E2E test:

Step #17: --- FAIL: TestGameServerUnhealthyAfterDeletingPod (88.45s)
Step #17: gameserver_test.go:211: 
Step #17: Error Trace:	gameserver_test.go:211
Step #17: Error: Received unexpected error:
Step #17: timed out waiting for the condition
Step #17: waiting for GameServer to be Unhealthy default/udp-serverjrtf8

@aLekSer
Fix Reference docs and sync it with Examples dir
36fd8e7 
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For googleforgames#969.
@aLekSer aLekSer force-pushed the fix/example-documentation branch from ef414b2 to 36fd8e7 Compare July 31, 2019 19:31
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c821e481-91a5-4093-9f0f-f78265d3ae8f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/970/head:pr_970 && git checkout pr_970
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-36fd8e7

@roberthbailey roberthbailey merged commit 4a78e86 into googleforgames:master Jul 31, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 31, 2019
Closed
6 tasks
@markmandel markmandel added this to the 0.12.0 milestone Aug 1, 2019
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aLekSer @agones-bot @roberthbailey @markmandel