-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all yaml files in the examples directory use working configurations / images #969
Comments
webhookfleetautoscaler.yaml and webhookfleetautoscalertls.yaml are used in https://agones.dev/site/docs/getting-started/create-webhook-fleetautoscaler/ which I've gone through recently so those ones should be fine. |
The fleet.yaml file appears to be ok already: $ kubectl apply -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/fleet.yaml
fleet.agones.dev/fleet-example created
$ kubectl get gs
NAME STATE ADDRESS PORT NODE AGE
fleet-example-shz66-bmqx5 Ready 104.196.251.83 7427 gke-test-cluster-default-07171326-f5n8 8s
fleet-example-shz66-lpcdw Ready 104.196.251.83 7087 gke-test-cluster-default-07171326-f5n8 8s |
Likewise, fleetautoscaler.yaml appears fine too. |
@aLekSer has a PR to fix gameserver.yaml, which just leaves gameserverallocation.yaml and the website update. |
We may also want to update the website's pages under Reference to include any updates to the files. Right now most of them inline a yaml and link to the examples folder, but it would be nice if the inlined yaml matched what was in the examples folder. |
|
There was a discrepancy between website agones.dev and Examples dir yaml files content. For googleforgames#969.
There was a discrepancy between website agones.dev and Examples dir yaml files content. For googleforgames#969.
There was a discrepancy between website agones.dev and Examples dir yaml files content. For googleforgames#969.
There was a discrepancy between website agones.dev and Examples dir yaml files content. For googleforgames#969.
I think we can cross out |
There was a discrepancy between website agones.dev and Examples dir yaml files content. For #969.
Fixed by #970 |
Files to verify / update:
We also need to update https://agones.dev/site/docs/examples/ for the 0.12 release to remove the working about the examples not being functional.
The text was updated successfully, but these errors were encountered: