Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all yaml files in the examples directory use working configurations / images #969

Closed
6 tasks done
roberthbailey opened this issue Jul 31, 2019 · 8 comments
Closed
6 tasks done
Assignees
Labels
kind/feature New features for Agones
Milestone

Comments

@roberthbailey
Copy link
Member

roberthbailey commented Jul 31, 2019

Files to verify / update:

  • fleet.yaml
  • fleetautoscaler.yaml
  • gameserver.yaml
  • gameserverallocation.yaml
  • webhookfleetautoscaler.yaml
  • webhookfleetautoscalertls.yaml

We also need to update https://agones.dev/site/docs/examples/ for the 0.12 release to remove the working about the examples not being functional.

@roberthbailey
Copy link
Member Author

webhookfleetautoscaler.yaml and webhookfleetautoscalertls.yaml are used in https://agones.dev/site/docs/getting-started/create-webhook-fleetautoscaler/ which I've gone through recently so those ones should be fine.

@roberthbailey
Copy link
Member Author

The fleet.yaml file appears to be ok already:

$ kubectl apply -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/fleet.yaml
fleet.agones.dev/fleet-example created
$ kubectl get gs
NAME                        STATE   ADDRESS          PORT   NODE                                     AGE
fleet-example-shz66-bmqx5   Ready   104.196.251.83   7427   gke-test-cluster-default-07171326-f5n8   8s
fleet-example-shz66-lpcdw   Ready   104.196.251.83   7087   gke-test-cluster-default-07171326-f5n8   8s

@roberthbailey
Copy link
Member Author

Likewise, fleetautoscaler.yaml appears fine too.

@roberthbailey
Copy link
Member Author

@aLekSer has a PR to fix gameserver.yaml, which just leaves gameserverallocation.yaml and the website update.

@roberthbailey
Copy link
Member Author

We may also want to update the website's pages under Reference to include any updates to the files. Right now most of them inline a yaml and link to the examples folder, but it would be nice if the inlined yaml matched what was in the examples folder.

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 31, 2019

gameserverallocation.yaml is fine.
In order to use it we need next fleet.yaml configuration:

apiVersion: "agones.dev/v1"
kind: Fleet
metadata:
  name: green-fleet
spec:
  replicas: 2
  template:
    metadata:
      labels:
        game: my-game
        tier: cache
    spec:
      ports:
      - name: default
        containerPort: 7654
      template:
        spec:
          containers:
          - name: simple-udp
            image: gcr.io/agones-images/udp-server:0.14

aLekSer added a commit to aLekSer/agones that referenced this issue Jul 31, 2019
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For googleforgames#969.
aLekSer added a commit to aLekSer/agones that referenced this issue Jul 31, 2019
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For googleforgames#969.
aLekSer added a commit to aLekSer/agones that referenced this issue Jul 31, 2019
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For googleforgames#969.
aLekSer added a commit to aLekSer/agones that referenced this issue Jul 31, 2019
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For googleforgames#969.
@aLekSer
Copy link
Collaborator

aLekSer commented Jul 31, 2019

I think we can cross out gameserverallocation now.

roberthbailey pushed a commit that referenced this issue Jul 31, 2019
There was a discrepancy between website agones.dev and Examples dir
yaml files content.
For #969.
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 31, 2019
@roberthbailey
Copy link
Member Author

Fixed by #970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

2 participants