Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the nodejs example to build in a docker image #945

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Update the nodejs example to build in a docker image #945

merged 2 commits into from
Jul 26, 2019

Conversation

roberthbailey
Copy link
Member

Fixes #943.
Fixes #728.
Fixes #868.

This PR also bumps the js-yaml dependency.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 15f8968d-2f41-4fa2-98a3-5529e8c80100

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/945/head:pr_945 && git checkout pr_945
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-847dcca

@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory area/security Issues pertaining to security kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 24, 2019
markmandel
markmandel reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small questions, but otherwise looks good.

examples/nodejs-simple/Dockerfile Show resolved Hide resolved
examples/nodejs-simple/README.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0404c8b9-d230-4e4e-b4cb-423fd32ffb3f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/945/head:pr_945 && git checkout pr_945
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-32e2036

@roberthbailey roberthbailey marked this pull request as ready for review July 25, 2019 20:15
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 26e0bb94-c7a8-49f5-b59c-1939f477c76d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

Looks like e2e flaked so I restarted it.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 06973e59-0c45-457a-b6bd-e25dc411ebd1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a04b9021-575a-4bc8-8fcd-53752e5fc28a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Cleared helm, and restarted 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8c3bef10-fa74-4dae-8315-e3a35c1e6709

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/945/head:pr_945 && git checkout pr_945
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-2a9e19e

markmandel
markmandel approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential nit, bit of you don't like it, feel free to ignore.

Otherwise, lgtm! 🎉

examples/nodejs-simple/README.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ab120a39-e1d7-47c5-a27a-93cb22131a8d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/945/head:pr_945 && git checkout pr_945
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-6212da8

@roberthbailey
Update the nodejs example:
5a8719c 
- to build in a docker image.
- to follow the same pattern as the c++ example
- to have a tutorial for deploying in an agones cluster
@roberthbailey
Update the js-yaml dependency to fix a security vulnerability.
3dbc954
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5016539c-ee0d-4da7-abe1-0a763c31fe0e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/945/head:pr_945 && git checkout pr_945
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-3dbc954

@markmandel markmandel merged commit 20a4b09 into googleforgames:master Jul 26, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 26, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 26, 2019
Closed
@roberthbailey roberthbailey deleted the nodejs branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/examples Examples. Usually found in the `examples` directory area/security Issues pertaining to security area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
3 participants
@roberthbailey @agones-bot @markmandel