Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nodejs example to a docker build #943

Closed
roberthbailey opened this issue Jul 23, 2019 · 0 comments · Fixed by #945
Closed

Move nodejs example to a docker build #943

roberthbailey opened this issue Jul 23, 2019 · 0 comments · Fixed by #945
Assignees
@roberthbailey
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones
Milestone
0.12.0

Comments

@roberthbailey
Copy link
Member

Right now the nodejs example requires installing nodejs and npm locally on your machine. It would be nice if it could be build / tested without any additional local development tooling, leveraging docker containers like other examples (and the sdks).
@roberthbailey roberthbailey added the kind/feature New features for Agones label Jul 23, 2019
@roberthbailey roberthbailey self-assigned this Jul 24, 2019
@roberthbailey roberthbailey mentioned this issue Jul 24, 2019
Merged
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 24, 2019
@markmandel markmandel added this to the 0.12.0 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberthbailey roberthbailey

Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Update the nodejs example to build in a docker image roberthbailey/agones
2 participants
@markmandel @roberthbailey