Updates to the C++ SDK along with the simple example that exercises it. #934

roberthbailey · 2019-07-22T10:18:17Z

Part of #703.

I ran clang-format on examples/cpp-simple/server.cc which accounts for many of the changes. The only code changes were modifying stable::agones::... to agones::....

Both #855 and #904 broke the cpp-simple example code (which points to the need for us to have sdk conformance tests for C++):

In the former, include/agones/sdk.grpc.pb.h was no longer being installed with the sdk, which caused the sample code to no longer compile. I've restructured the cmake files a bit to make sure that it's now put into the expected place. /cc @dsazonoff
In the latter, the client context for the healthcheck calls was allocated on the stack in the constructor, but the healthchecks were continuously being called via the Health SDK function, which caused the program to abort abnormally due to a check failure. The code is now leaking a single client context, which we could clean up in the destructor if we wanted to be especially thorough (but in generally, since it has the same lifetime of the SDK and we expect the SDK to have the lifetime of the game server, this seemed not so bad compared to leaking one on each SDK call). /cc @devjgm

Note that I haven't pushed the 0.6 version of the container yet, since I have some questions about whether the updates I made to the SDK are correct.

agones-bot · 2019-07-22T10:20:16Z

Build Failed 😱

Build Id: 90149902-db47-4d2d-b32d-921a0af8479d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-22T10:45:34Z

Build Failed 😱

Build Id: ad053951-a78b-435e-b73a-f82b7c656c53

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-22T10:50:58Z

Build Succeeded 👏

Build Id: 8a753719-6659-41f4-a950-8c1451073da3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-5e7c02f
image: gcr.io/agones-images/agones-sdk:0.12.0-5e7c02f
image: gcr.io/agones-images/agones-ping:0.12.0-5e7c02f
Linux C++ SDK (build): agonessdk-0.12.0-5e7c02f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-5e7c02f.zip

A preview of the website (the last 30 builds are retained):

https://5e7c02f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-5e7c02f

examples/cpp-simple/README.md

examples/cpp-simple/server.cc

sdks/cpp/src/agones/sdk.cc

devjgm

Thanks for the updates.

examples/cpp-simple/README.md

examples/cpp-simple/server.cc

sdks/cpp/src/agones/sdk.cc

agones-bot · 2019-07-22T19:07:38Z

Build Failed 😱

Build Id: f5f8a44c-b985-402f-a535-0e1483b41a88

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-22T19:09:20Z

Build Failed 😱

Build Id: 301075d8-e263-4888-9f57-d15257250a6a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-22T19:12:07Z

Build Failed 😱

Build Id: 0910b584-4dc4-4d2b-a4bb-d80636422d16

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-22T22:35:06Z

Build Failed 😱

Build Id: aa4d4d4b-f5e8-4988-a217-0918622d397f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-23T04:49:44Z

Build Failed 😱

Build Id: 5f9f7585-188a-4f32-9eea-d73e9f45e2b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-23T04:57:00Z

Build Succeeded 👏

Build Id: 0ad35a03-0620-489d-88af-82a835479654

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-9187db9
image: gcr.io/agones-images/agones-sdk:0.12.0-9187db9
image: gcr.io/agones-images/agones-ping:0.12.0-9187db9
Linux C++ SDK (build): agonessdk-0.12.0-9187db9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-9187db9.zip

A preview of the website (the last 30 builds are retained):

https://9187db9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-9187db9

agones-bot · 2019-07-23T17:33:14Z

Build Succeeded 👏

Build Id: 9c293644-93ab-464c-bc51-c8a9f83d70cd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-7d214d3
image: gcr.io/agones-images/agones-sdk:0.12.0-7d214d3
image: gcr.io/agones-images/agones-ping:0.12.0-7d214d3
Linux C++ SDK (build): agonessdk-0.12.0-7d214d3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-7d214d3.zip

A preview of the website (the last 30 builds are retained):

https://7d214d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-7d214d3

agones-bot · 2019-07-23T18:32:39Z

Build Succeeded 👏

Build Id: 51026958-41e9-4102-bf91-36d94d145342

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-d9be549
image: gcr.io/agones-images/agones-sdk:0.12.0-d9be549
image: gcr.io/agones-images/agones-ping:0.12.0-d9be549
Linux C++ SDK (build): agonessdk-0.12.0-d9be549-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-d9be549.zip

A preview of the website (the last 30 builds are retained):

https://d9be549-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d9be549

agones-bot · 2019-07-23T18:41:00Z

Build Succeeded 👏

Build Id: 98c5f88d-e480-4f80-940f-d1210a86e00c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-5f7931b
image: gcr.io/agones-images/agones-sdk:0.12.0-5f7931b
image: gcr.io/agones-images/agones-ping:0.12.0-5f7931b
Linux C++ SDK (build): agonessdk-0.12.0-5f7931b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-5f7931b.zip

A preview of the website (the last 30 builds are retained):

https://5f7931b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-5f7931b

devjgm

Overall, looks good. Thanks for the updates to the docs -- very helpful for me. A few small questions/comments.

examples/cpp-simple/server.cc

roberthbailey · 2019-07-23T18:57:08Z

@devjgm - this is ready for review.

roberthbailey · 2019-07-23T19:33:08Z

Comments addressed; new version pushed.

agones-bot · 2019-07-23T20:07:19Z

Build Succeeded 👏

Build Id: 65d22200-e323-421b-ba1e-27828153505c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-f02db01
image: gcr.io/agones-images/agones-sdk:0.12.0-f02db01
image: gcr.io/agones-images/agones-ping:0.12.0-f02db01
Linux C++ SDK (build): agonessdk-0.12.0-f02db01-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-f02db01.zip

A preview of the website (the last 30 builds are retained):

https://f02db01-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-f02db01

roberthbailey · 2019-07-23T20:09:22Z

There was a compile error in the version where the build just succeeded, which makes it pretty clear that our CI doesn't compile the example code.

agones-bot · 2019-07-23T20:14:25Z

Build Succeeded 👏

Build Id: 753425f5-6d84-4296-80ce-fd601db9de76

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-dd8e8cc
image: gcr.io/agones-images/agones-sdk:0.12.0-dd8e8cc
image: gcr.io/agones-images/agones-ping:0.12.0-dd8e8cc
Linux C++ SDK (build): agonessdk-0.12.0-dd8e8cc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-dd8e8cc.zip

A preview of the website (the last 30 builds are retained):

https://dd8e8cc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-dd8e8cc

devjgm

Code changes LGTM. Thanks.

markmandel

Lgtm, just some docs questions.

examples/cpp-simple/README.md

agones-bot · 2019-07-24T01:40:38Z

Build Succeeded 👏

Build Id: fe4927fa-41af-411b-9b52-774013a68d93

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-cc468a8
image: gcr.io/agones-images/agones-sdk:0.12.0-cc468a8
image: gcr.io/agones-images/agones-ping:0.12.0-cc468a8
Linux C++ SDK (build): agonessdk-0.12.0-cc468a8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-cc468a8.zip

A preview of the website (the last 30 builds are retained):

https://cc468a8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-cc468a8

agones-bot · 2019-07-24T03:08:08Z

Build Succeeded 👏

Build Id: 09414444-8319-4c6a-8e52-eb13cd9a1a59

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-fd35fd0
image: gcr.io/agones-images/agones-sdk:0.12.0-fd35fd0
image: gcr.io/agones-images/agones-ping:0.12.0-fd35fd0
Linux C++ SDK (build): agonessdk-0.12.0-fd35fd0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-fd35fd0.zip

A preview of the website (the last 30 builds are retained):

https://fd35fd0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-fd35fd0

agones-bot · 2019-07-24T19:24:07Z

Build Succeeded 👏

Build Id: 96a13ffb-1f0b-400b-97d6-ce22d80f7a8c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-128890d
image: gcr.io/agones-images/agones-sdk:0.12.0-128890d
image: gcr.io/agones-images/agones-ping:0.12.0-128890d
Linux C++ SDK (build): agonessdk-0.12.0-128890d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-128890d.zip

A preview of the website (the last 30 builds are retained):

https://128890d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-128890d

agones-bot · 2019-07-24T19:31:29Z

Build Succeeded 👏

Build Id: d43e6adb-5616-4750-a90c-9d9a045a40ac

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-a5ffbd0
image: gcr.io/agones-images/agones-sdk:0.12.0-a5ffbd0
image: gcr.io/agones-images/agones-ping:0.12.0-a5ffbd0
Linux C++ SDK (build): agonessdk-0.12.0-a5ffbd0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-a5ffbd0.zip

A preview of the website (the last 30 builds are retained):

https://a5ffbd0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-a5ffbd0

it. Create a tutorial to show how to build / run the simple C++ example.

roberthbailey · 2019-07-25T04:08:31Z

I've fixed the output buffering issues in the latest version. This should now be ready for another review pass.

agones-bot · 2019-07-25T04:39:39Z

Build Succeeded 👏

Build Id: 981d47d3-bd16-42a5-8fb9-7eec92660f39

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-d7a7b97
image: gcr.io/agones-images/agones-sdk:0.12.0-d7a7b97
image: gcr.io/agones-images/agones-ping:0.12.0-d7a7b97
Linux C++ SDK (build): agonessdk-0.12.0-d7a7b97-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-d7a7b97.zip

A preview of the website (the last 30 builds are retained):

https://d7a7b97-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/934/head:pr_934 && git checkout pr_934
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d7a7b97

markmandel

This is great!

roberthbailey · 2019-07-25T11:21:20Z

I've built gcr.io/agones-images/cpp-simple-server:0.9 from the new master branch and pushed it.

roberthbailey force-pushed the cpp-simple branch from c89eb19 to 5e7c02f Compare July 22, 2019 10:19

devjgm reviewed Jul 22, 2019

View reviewed changes

roberthbailey force-pushed the cpp-simple branch 2 times, most recently from 6705608 to 287f70d Compare July 22, 2019 18:47

devjgm reviewed Jul 22, 2019

View reviewed changes

examples/cpp-simple/README.md Outdated Show resolved Hide resolved

examples/cpp-simple/server.cc Outdated Show resolved Hide resolved

examples/cpp-simple/server.cc Show resolved Hide resolved

sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved

roberthbailey force-pushed the cpp-simple branch 2 times, most recently from 749fc1b to 9187db9 Compare July 23, 2019 04:18

roberthbailey force-pushed the cpp-simple branch from 9187db9 to 7d214d3 Compare July 23, 2019 17:00

roberthbailey force-pushed the cpp-simple branch 2 times, most recently from d9be549 to 5f7931b Compare July 23, 2019 18:04

devjgm reviewed Jul 23, 2019

View reviewed changes

roberthbailey mentioned this pull request Jul 23, 2019

C++ SDK: Use const-reference in WatchGameServer #941

Closed

roberthbailey force-pushed the cpp-simple branch from 5f7931b to f02db01 Compare July 23, 2019 19:32

roberthbailey force-pushed the cpp-simple branch from f02db01 to dd8e8cc Compare July 23, 2019 19:33

roberthbailey mentioned this pull request Jul 23, 2019

CI testing should catch compile errors in the example code #942

Open

devjgm approved these changes Jul 24, 2019

View reviewed changes

markmandel reviewed Jul 24, 2019

View reviewed changes

examples/cpp-simple/README.md Outdated Show resolved Hide resolved

examples/cpp-simple/README.md Outdated Show resolved Hide resolved

examples/cpp-simple/README.md Outdated Show resolved Hide resolved

roberthbailey force-pushed the cpp-simple branch from dd8e8cc to cc468a8 Compare July 24, 2019 01:07

roberthbailey force-pushed the cpp-simple branch from cc468a8 to fd35fd0 Compare July 24, 2019 02:33

roberthbailey force-pushed the cpp-simple branch from 128890d to a5ffbd0 Compare July 24, 2019 18:57

Updates to the C++ SDK along with the simple example that exercises

d7a7b97

it. Create a tutorial to show how to build / run the simple C++ example.

roberthbailey force-pushed the cpp-simple branch from a5ffbd0 to d7a7b97 Compare July 25, 2019 04:06

devjgm approved these changes Jul 25, 2019

View reviewed changes

markmandel approved these changes Jul 25, 2019

View reviewed changes

markmandel merged commit 5ec9dfa into googleforgames:master Jul 25, 2019

roberthbailey mentioned this pull request Jul 26, 2019

Proposal: Split up the api group stable.agones.dev #703

Closed

roberthbailey added this to the 0.12.0 milestone Jul 26, 2019

markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones kind/feature New features for Agones labels Aug 1, 2019

roberthbailey deleted the cpp-simple branch August 1, 2019 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to the C++ SDK along with the simple example that exercises it. #934

Updates to the C++ SDK along with the simple example that exercises it. #934

roberthbailey commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

devjgm left a comment

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

devjgm left a comment

roberthbailey commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

agones-bot commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

agones-bot commented Jul 23, 2019

devjgm left a comment

markmandel left a comment

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 25, 2019

markmandel left a comment

roberthbailey commented Jul 25, 2019

Updates to the C++ SDK along with the simple example that exercises it. #934

Updates to the C++ SDK along with the simple example that exercises it. #934

Conversation

roberthbailey commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

devjgm left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 22, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

agones-bot commented Jul 23, 2019

devjgm left a comment

Choose a reason for hiding this comment

roberthbailey commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

agones-bot commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

agones-bot commented Jul 23, 2019

devjgm left a comment

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

agones-bot commented Jul 24, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 25, 2019

markmandel left a comment

Choose a reason for hiding this comment

roberthbailey commented Jul 25, 2019