Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp clang-format #855

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Cpp clang-format #855

merged 1 commit into from
Jul 13, 2019

Conversation

dsazonoff
Copy link
Contributor

@dsazonoff dsazonoff commented Jun 26, 2019

PR for #713 issue.
Added support of clang-format as a pre-build step (optional, useful for SDK contributors)
Added clang-format code style verification as a build step. Build will fail if SDK code is not following google code style (not applied for generated files).
Waiting for #803 to be merged in...

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9d5bc9f4-c065-478b-8520-cb7a184693e9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb4aa6e7-c008-411a-9219-397210129a9e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/855/head:pr_855 && git checkout pr_855
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-80c816a

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 517d1599-1085-4c84-8149-97e1a2bb7c4e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/855/head:pr_855 && git checkout pr_855
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-625fd75

@dsazonoff
Copy link
Contributor Author

dsazonoff commented Jul 12, 2019

Example of output (#900 ):

clang-format code style check failed for: sdks/cpp/src/agones/sdk.cc

@markmandel here is PR for #713 issue.
@roberthbailey could you help with code review, please?

@dsazonoff dsazonoff marked this pull request as ready for review July 12, 2019 19:46
@roberthbailey
Copy link
Member

I'm not an expert on cmake (so if anyone is I'd appreciate their review) but I don't see any obvious issues with this change, and from #900 it appears to be validating that formatting has been successfully applied to the source files.

@dsazonoff
Copy link
Contributor Author

@sylvainduchesne, could you do a code review, please?

@dsazonoff dsazonoff mentioned this pull request Jul 12, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel merged commit a6b604e into googleforgames:master Jul 13, 2019
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants