-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cpp clang-format #855
Cpp clang-format #855
Conversation
Build Failed 😱 Build Id: 9d5bc9f4-c065-478b-8520-cb7a184693e9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: fb4aa6e7-c008-411a-9219-397210129a9e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 517d1599-1085-4c84-8149-97e1a2bb7c4e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Example of output (#900 ):
@markmandel here is PR for #713 issue. |
I'm not an expert on cmake (so if anyone is I'd appreciate their review) but I don't see any obvious issues with this change, and from #900 it appears to be validating that formatting has been successfully applied to the source files. |
@sylvainduchesne, could you do a code review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR for #713 issue.
Added support of clang-format as a pre-build step (optional, useful for SDK contributors)
Added clang-format code style verification as a build step. Build will fail if SDK code is not following google code style (not applied for generated files).
Waiting for #803 to be merged in...