Helm support for Terraform #696

aLekSer · 2019-04-09T15:10:17Z

Deploying agones using agones.dev chart. Version is specified in helm.tf config.

Two options of installation:

ability to install current version of sourcecode like make install does.
install release version from helm repo.
This Pull Request adds an ability to install Agones along with creating the cluster using Terraform.

Contains part of #670 Pull Request, so leave it as draft until rebased with new master.

For #657.

agones-bot · 2019-04-09T15:24:56Z

Build Succeeded 👏

Build Id: 8cfb6b56-8150-4760-b25e-878a75d107a1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-60c1e02
image: gcr.io/agones-images/agones-sdk:0.10.0-60c1e02
image: gcr.io/agones-images/agones-ping:0.10.0-60c1e02
Linux C++ SDK (build): agonessdk-0.10.0-60c1e02-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-60c1e02.zip

A preview of the website (the last 30 builds are retained):

https://60c1e02-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-60c1e02

agones-bot · 2019-04-09T15:53:44Z

Build Failed 😱

Build Id: 60b46c96-4272-413c-9b9b-3c7b5c77a44a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-10T08:48:00Z

Build Failed 😱

Build Id: be0b185a-5d99-456f-a5da-e2542fa07a08

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-10T14:02:27Z

Build Succeeded 👏

Build Id: aea04b64-9318-4a00-ba74-b0266304df8a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-afb7d73
image: gcr.io/agones-images/agones-sdk:0.10.0-afb7d73
image: gcr.io/agones-images/agones-ping:0.10.0-afb7d73
Linux C++ SDK (build): agonessdk-0.10.0-afb7d73-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-afb7d73.zip

A preview of the website (the last 30 builds are retained):

https://afb7d73-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-afb7d73

agones-bot · 2019-04-11T11:47:07Z

Build Failed 😱

Build Id: b4414958-d502-4e66-8ca1-26309816a331

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-11T11:55:22Z

Build Failed 😱

Build Id: 31b65a77-cef4-4b03-be9e-ca01cccde7e9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-11T13:09:46Z

Build Succeeded 👏

Build Id: 54f76f26-fad9-49f2-9c0a-c734d4ec8bbb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-f590a34
image: gcr.io/agones-images/agones-sdk:0.10.0-f590a34
image: gcr.io/agones-images/agones-ping:0.10.0-f590a34
Linux C++ SDK (build): agonessdk-0.10.0-f590a34-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-f590a34.zip

A preview of the website (the last 30 builds are retained):

https://f590a34-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-f590a34

agones-bot · 2019-04-11T13:19:06Z

Build Succeeded 👏

Build Id: 65294f0c-6f24-4b12-9225-c007aa1e7fc5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-1b05a96
image: gcr.io/agones-images/agones-sdk:0.10.0-1b05a96
image: gcr.io/agones-images/agones-ping:0.10.0-1b05a96
Linux C++ SDK (build): agonessdk-0.10.0-1b05a96-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-1b05a96.zip

A preview of the website (the last 30 builds are retained):

https://1b05a96-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-1b05a96

agones-bot · 2019-04-11T13:50:33Z

Build Failed 😱

Build Id: 14c62b8d-7f66-43bc-9870-7245759383b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-11T14:55:18Z

Build Failed 😱

Build Id: a94d7191-c5c4-453e-a218-83c363b5a92f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-11T15:02:26Z

Build Succeeded 👏

Build Id: bd213ac5-ce6d-4778-adbb-79e452bfa1e1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-063cd3a
image: gcr.io/agones-images/agones-sdk:0.10.0-063cd3a
image: gcr.io/agones-images/agones-ping:0.10.0-063cd3a
Linux C++ SDK (build): agonessdk-0.10.0-063cd3a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-063cd3a.zip

A preview of the website (the last 30 builds are retained):

https://063cd3a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-063cd3a

agones-bot · 2019-04-11T15:53:58Z

Build Succeeded 👏

Build Id: 0c02bbaa-d8f8-4506-ae60-2807ccf91da9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-53b68eb
image: gcr.io/agones-images/agones-sdk:0.10.0-53b68eb
image: gcr.io/agones-images/agones-ping:0.10.0-53b68eb
Linux C++ SDK (build): agonessdk-0.10.0-53b68eb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-53b68eb.zip

A preview of the website (the last 30 builds are retained):

https://53b68eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-53b68eb

agones-bot · 2019-04-16T10:55:01Z

Build Succeeded 👏

Build Id: 3e44dde8-88ee-409a-8e5c-b48a5adc52f1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-33015ab
image: gcr.io/agones-images/agones-sdk:0.10.0-33015ab
image: gcr.io/agones-images/agones-ping:0.10.0-33015ab
Linux C++ SDK (build): agonessdk-0.10.0-33015ab-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-33015ab.zip

A preview of the website (the last 30 builds are retained):

https://33015ab-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-33015ab

agones-bot · 2019-04-16T15:02:41Z

Build Succeeded 👏

Build Id: 12ed7db8-5bce-4ed1-9552-b7ba103e42e4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-96c6d54
image: gcr.io/agones-images/agones-sdk:0.10.0-96c6d54
image: gcr.io/agones-images/agones-ping:0.10.0-96c6d54
Linux C++ SDK (build): agonessdk-0.10.0-96c6d54-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-96c6d54.zip

A preview of the website (the last 30 builds are retained):

https://96c6d54-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-96c6d54

agones-bot · 2019-04-17T14:12:59Z

Build Succeeded 👏

Build Id: 8acbb7ca-614b-4e4b-810d-a786cdab6962

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-e9c923d
image: gcr.io/agones-images/agones-sdk:0.10.0-e9c923d
image: gcr.io/agones-images/agones-ping:0.10.0-e9c923d
Linux C++ SDK (build): agonessdk-0.10.0-e9c923d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-e9c923d.zip

A preview of the website (the last 30 builds are retained):

https://e9c923d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e9c923d

agones-bot · 2019-04-17T14:15:53Z

Build Succeeded 👏

Build Id: 1afd6873-2a6b-4fef-b197-7ad51650ec6a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-5c26ffa
image: gcr.io/agones-images/agones-sdk:0.10.0-5c26ffa
image: gcr.io/agones-images/agones-ping:0.10.0-5c26ffa
Linux C++ SDK (build): agonessdk-0.10.0-5c26ffa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-5c26ffa.zip

A preview of the website (the last 30 builds are retained):

https://5c26ffa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-5c26ffa

agones-bot · 2019-04-17T14:50:59Z

Build Failed 😱

Build Id: 3476afc9-ee28-454b-a03b-ad18858ac088

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-17T14:57:12Z

Build Succeeded 👏

Build Id: 1933fa71-cb76-41f4-a59f-6491daf53987

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-2b297cd
image: gcr.io/agones-images/agones-sdk:0.10.0-2b297cd
image: gcr.io/agones-images/agones-ping:0.10.0-2b297cd
Linux C++ SDK (build): agonessdk-0.10.0-2b297cd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-2b297cd.zip

A preview of the website (the last 30 builds are retained):

https://2b297cd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-2b297cd

agones-bot · 2019-04-18T12:46:43Z

Build Failed 😱

Build Id: 23f99e1d-e209-496e-88d6-c71eba2abcb2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-19T10:05:55Z

Build Failed 😱

Build Id: 0687462c-c675-441c-b179-20be7925555a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-19T11:06:49Z

Build Succeeded 👏

Build Id: 52820e77-523b-489e-8a66-6cb31e626302

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-e1b69b9
image: gcr.io/agones-images/agones-sdk:0.10.0-e1b69b9
image: gcr.io/agones-images/agones-ping:0.10.0-e1b69b9
Linux C++ SDK (build): agonessdk-0.10.0-e1b69b9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-e1b69b9.zip

A preview of the website (the last 30 builds are retained):

https://e1b69b9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e1b69b9

markmandel

This is kinda awesome 😄 Just have some niggly things I'd like to double check on. But I'm pretty excited about this!

/cc @Kuqd who has way more terraform experience than I.

markmandel · 2019-04-19T17:41:57Z

build/includes/google-cloud.mk

 gcloud-terraform-cluster: GCP_CLUSTER_LEGACYABAC ?= false
 gcloud-terraform-cluster: GCP_CLUSTER_NODEPOOL_INITIALNODECOUNT ?= 4
 gcloud-terraform-cluster: GCP_CLUSTER_NODEPOOL_MACHINETYPE ?= n1-standard-4
+gcloud-terraform-cluster: AGONES_VERSION ?= 0.9.0


I can't think of a better param than this - I just see it going out of date as releases continue forward.

Can we default to '' which will install the latest chart, and then have an optional override?

build/includes/google-cloud.mk

markmandel · 2019-04-19T17:44:07Z

examples/terraform-submodule/module.tf

+   default= ""
+}
+variable "agones_version" {
+  default="0.9.0"


I'm just hesitant to set the version as default. I already have a long list of things to update on release - this just adds another one. Can we use the helm default of installing the latest, with the ability to override?

markmandel · 2019-04-19T17:45:15Z

site/content/en/docs/Installation/terraform.md

@@ -0,0 +1,65 @@
+---
+title: "Install Agones using Terraform"


Do we want to be clear this is GKE only somehow?

site/content/en/docs/Installation/terraform.md

agones-bot · 2019-04-22T13:22:40Z

Build Failed 😱

Build Id: e486fa45-d810-4324-8688-34f82725ad58

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-04-22T14:32:12Z

Hello @markmandel ,
I have applied all comments above, please check.
Basically I removed "agones_version" default value.
"agones.image.tag" becomes optional.
So we have two separate make targets:

make gcloud-terraform-cluster will install production version.
make gcloud-terraform-install will install current development version which is equivalent of running make gcloud-test-cluster and make install at the same time.

agones-bot · 2019-04-22T14:36:20Z

Build Failed 😱

Build Id: 5a303fa9-b7f4-4043-ae38-27b58973c4c1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Deploying agones using two options: 1. From repository release charts by specifying version. 2. Local version using Chart.yaml file with values.yaml.

agones-bot · 2019-04-22T15:43:33Z

Build Succeeded 👏

Build Id: 8fbae0aa-8b7b-4996-b664-65dfbc03784d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-f6444b3
image: gcr.io/agones-images/agones-sdk:0.10.0-f6444b3
image: gcr.io/agones-images/agones-ping:0.10.0-f6444b3
Linux C++ SDK (build): agonessdk-0.10.0-f6444b3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-f6444b3.zip

A preview of the website (the last 30 builds are retained):

https://f6444b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-f6444b3

agones-bot · 2019-04-23T19:00:31Z

Build Succeeded 👏

Build Id: bffbab42-681a-4f5b-bb89-eb4c9a34ffde

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-e12de33
image: gcr.io/agones-images/agones-sdk:0.10.0-e12de33
image: gcr.io/agones-images/agones-ping:0.10.0-e12de33
Linux C++ SDK (build): agonessdk-0.10.0-e12de33-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-e12de33.zip

A preview of the website (the last 30 builds are retained):

https://e12de33-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/696/head:pr_696 && git checkout pr_696
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e12de33

aLekSer changed the title ~~Add helm terraform config~~ Add Helm Terraform config Apr 9, 2019

aLekSer force-pushed the feature/helm-terraform branch from 60c1e02 to b24921e Compare April 9, 2019 15:23

aLekSer force-pushed the feature/helm-terraform branch from b24921e to 17caae7 Compare April 10, 2019 08:32

aLekSer force-pushed the feature/helm-terraform branch from 17caae7 to afb7d73 Compare April 10, 2019 13:48

aLekSer force-pushed the feature/helm-terraform branch 2 times, most recently from 1f26549 to 7ba51a8 Compare April 11, 2019 11:33

aLekSer force-pushed the feature/helm-terraform branch 2 times, most recently from f590a34 to 1b05a96 Compare April 11, 2019 13:04

aLekSer force-pushed the feature/helm-terraform branch from 1b05a96 to 7bce733 Compare April 11, 2019 13:35

aLekSer force-pushed the feature/helm-terraform branch 2 times, most recently from c34fa3a to 063cd3a Compare April 11, 2019 14:48

aLekSer force-pushed the feature/helm-terraform branch from 063cd3a to 53b68eb Compare April 11, 2019 15:38

aLekSer force-pushed the feature/helm-terraform branch from 53b68eb to 33015ab Compare April 16, 2019 10:30

aLekSer force-pushed the feature/helm-terraform branch from 33015ab to 96c6d54 Compare April 16, 2019 14:38

aLekSer force-pushed the feature/helm-terraform branch 2 times, most recently from 7827d0c to 59e99d0 Compare April 16, 2019 16:36

aLekSer changed the title ~~Add Helm Terraform config~~ Helm support for Terraform Apr 17, 2019

aLekSer force-pushed the feature/helm-terraform branch from 5c26ffa to f936550 Compare April 17, 2019 14:27

aLekSer marked this pull request as ready for review April 17, 2019 14:28

aLekSer force-pushed the feature/helm-terraform branch from f936550 to 2b297cd Compare April 17, 2019 14:34

aLekSer force-pushed the feature/helm-terraform branch from 2b297cd to b48b480 Compare April 18, 2019 12:30

aLekSer force-pushed the feature/helm-terraform branch from b48b480 to e9a0f4b Compare April 19, 2019 09:52

aLekSer force-pushed the feature/helm-terraform branch from e9a0f4b to e1b69b9 Compare April 19, 2019 10:41

markmandel reviewed Apr 19, 2019

View reviewed changes

aLekSer force-pushed the feature/helm-terraform branch from e1b69b9 to cc6a9fb Compare April 22, 2019 13:00

aLekSer force-pushed the feature/helm-terraform branch from cc6a9fb to 18584ba Compare April 22, 2019 14:13

Add helm terraform config

f6444b3

Deploying agones using two options: 1. From repository release charts by specifying version. 2. Local version using Chart.yaml file with values.yaml.

aLekSer force-pushed the feature/helm-terraform branch from 18584ba to f6444b3 Compare April 22, 2019 15:18

cyriltovena approved these changes Apr 23, 2019

View reviewed changes

Merge branch 'master' into feature/helm-terraform

e12de33

markmandel merged commit ecf52c1 into googleforgames:master Apr 23, 2019

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Apr 27, 2019

markmandel added this to the 0.10.0 milestone Apr 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm support for Terraform #696

Helm support for Terraform #696

aLekSer commented Apr 9, 2019 •

edited

Loading

agones-bot commented Apr 9, 2019

agones-bot commented Apr 9, 2019

agones-bot commented Apr 10, 2019

agones-bot commented Apr 10, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 16, 2019

agones-bot commented Apr 16, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 18, 2019

agones-bot commented Apr 19, 2019

agones-bot commented Apr 19, 2019

markmandel left a comment

markmandel Apr 19, 2019

markmandel Apr 19, 2019

markmandel Apr 19, 2019

agones-bot commented Apr 22, 2019

aLekSer commented Apr 22, 2019

agones-bot commented Apr 22, 2019

agones-bot commented Apr 22, 2019

agones-bot commented Apr 23, 2019

Helm support for Terraform #696

Helm support for Terraform #696

Conversation

aLekSer commented Apr 9, 2019 • edited Loading

agones-bot commented Apr 9, 2019

agones-bot commented Apr 9, 2019

agones-bot commented Apr 10, 2019

agones-bot commented Apr 10, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 11, 2019

agones-bot commented Apr 16, 2019

agones-bot commented Apr 16, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 17, 2019

agones-bot commented Apr 18, 2019

agones-bot commented Apr 19, 2019

agones-bot commented Apr 19, 2019

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 19, 2019

Choose a reason for hiding this comment

markmandel Apr 19, 2019

Choose a reason for hiding this comment

markmandel Apr 19, 2019

Choose a reason for hiding this comment

agones-bot commented Apr 22, 2019

aLekSer commented Apr 22, 2019

agones-bot commented Apr 22, 2019

agones-bot commented Apr 22, 2019

agones-bot commented Apr 23, 2019

aLekSer commented Apr 9, 2019 •

edited

Loading