-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform support to generate test cluster #670
Terraform support to generate test cluster #670
Conversation
5131219
to
25e433e
Compare
Build Failed 😱 Build Id: 8031319f-3d81-45ce-99eb-acbf04384355 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 8b478815-267d-40a1-8227-cace3007b59e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
05310a3
to
96bb165
Compare
Build Succeeded 👏 Build Id: 9922ce9f-0d4a-4c24-abbf-6227c2b93a4a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: ab8516fa-603f-4fb5-b538-4c8d5b17a316 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
a8d3c44
to
c7ba721
Compare
Build Succeeded 👏 Build Id: 66969b53-d74f-4b4a-89ac-e1f45a2c21c8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: d17571f8-a805-42e7-a185-76bc890ce52c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
build/gke-test-cluster/cluster.tf
Outdated
|
||
master_auth { | ||
username = "admin" | ||
password = "supersecretpassword" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be externalized and perhaps even set to fail if not changed from the default (perhaps we shouldn't even have a default for this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a clone of what we have in jinja template:
https://github.com/GoogleCloudPlatform/agones/blob/7368392ed6f2ca4cb42c34f53ef6d6a0730227c3/build/gke-test-cluster/cluster.yml.jinja#L75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added env variable for that, also we can use password = "${random_string.password.result}"
:
https://medium.com/@tsadoklf/cloud-recipes-use-terraform-to-create-kubernetes-cluster-and-memorystore-redis-instance-on-gcp-d51bb53df46a
build/gke-test-cluster/cluster.tf
Outdated
@@ -0,0 +1,153 @@ | |||
# Copyright 2019 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in "build" - given that this will likely be our 'here's our opinionated way to install a cluster + Agones' - should this be in a more central place? What do you all think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can move this up to a "build" folder. Thinking on how to make this method of creating cluster universal (cloud platform agnostic), but this definitely would be separate change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will refactor this tf file a bit.
build/gke-test-cluster/cluster.tf
Outdated
@@ -0,0 +1,153 @@ | |||
# Copyright 2019 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can move this up to a "build" folder. Thinking on how to make this method of creating cluster universal (cloud platform agnostic), but this definitely would be separate change.
c7ba721
to
f79c77d
Compare
Build Succeeded 👏 Build Id: 86a2eb07-8519-44fc-b15c-614eb5d7f505 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
} | ||
|
||
variable "cluster" { | ||
type = "map" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: you could add a small description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this PR :)
f79c77d
to
89cdcc9
Compare
Build Succeeded 👏 Build Id: 2224cb53-3647-4fc4-9d52-c2bd139e9cd4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
89cdcc9
to
db79f50
Compare
New version contains a one resource for
|
50b09d9
to
27d1857
Compare
Build Succeeded 👏 Build Id: 8836e337-a54c-4b03-9809-9bc5fe1037cd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
27d1857
to
89601c6
Compare
Build Failed 😱 Build Id: 70d2c452-47d6-444e-8072-043a9200d90d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
89601c6
to
f2150b9
Compare
Build Succeeded 👏 Build Id: 33a3a699-8b3d-4c19-8f1a-7f642ce100c2 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
f49516d
to
d289704
Compare
Build Succeeded 👏 Build Id: d44bffb5-a2a9-459c-a853-89b306b22d23 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
d289704
to
fa9b949
Compare
@bbf I made password basic authentication optional. Reflected in |
Build Succeeded 👏 Build Id: a3b583d9-d93e-49b0-87fe-e4fdd4edf4ec The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 4503b8cd-5b75-461d-94eb-d38a3b4a19e5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'coupla questions 👍
@@ -379,6 +379,13 @@ The Kubernetes config file used to access the cluster. Defaults to `~/.kube/conf | |||
### CLUSTER_NAME | |||
The (gcloud) test cluster that is being worked against. Defaults to `test-cluster` | |||
|
|||
### GCP_PROJECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this default to the gcp project that is configured in make gcloud-init
?
build/README.md
Outdated
#### `make gcloud-terraform-cluster` | ||
Run next command with your project ID specified: | ||
``` | ||
GCP_PROJECT=<YOUR_PROJECT_ID> [GKE_PASSWORD="<YOUR_PASSWORD>"] make gcloud-terraform-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a default project in gcloud
- I take it that these two things are not linked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are linked, but I think here is better to have an option to explicitly choose, which project you are going to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally removed the GCP_PROJECT as prerequisites , I am setting it using gcloud
command if not set.
fa9b949
to
f83f0d5
Compare
Build Succeeded 👏 Build Id: 0e1778a6-9ff1-4274-bea3-3329a1f149b3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
f83f0d5
to
9e67fc1
Compare
Build Succeeded 👏 Build Id: 5dd616fa-37a1-47d3-8e56-6e27fc23a13d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
9e67fc1
to
d5cda35
Compare
Creating GKE cluster with three node pools: system, metrics, gameservers. Added tfvars parameters and new make targets. E2E tests pass on a terraform deployed cluster.
d5cda35
to
a1e477a
Compare
Build Succeeded 👏 Build Id: b717c1d3-1cc2-4c69-a451-b2eb90c60bcd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 9c2bc75c-da78-4796-af2a-68e35d8f43fa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
E2E test passed.
New make targets:
Need to add install step of agones.
For #657 .