Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet and Gameserverset Validation handler #598

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Add Fleet and Gameserverset Validation handler #598

merged 2 commits into from
Feb 21, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 18, 2019 •
edited
Loading

Add Fleet and GSS Name length check on Create and Update in order to prevent GSS label overflowing.
For #541 .

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 686f7f13-a361-473a-b59c-596d3bf6967e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/598/head:pr_598 && git checkout pr_598
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-c817dc2

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 18, 2019
markmandel
markmandel reviewed Feb 18, 2019
View reviewed changes
pkg/apis/stable/v1alpha1/fleet.go Outdated
// Validate validates the Fleet configuration.
// If a Fleet is invalid there will be > 0 values in
// the returned array
func (f *Fleet) Validate() (bool, []metav1.StatusCause) {
Copy link
Member

@markmandel markmandel Feb 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something I'm fixing elsewhere, for the other validate functions (PR incoming) - I think we should fix the return value, so the return should be: ([]metav1.StatusCause, bool) - just because that's what we do in go for everything else.

Check a map: v, ok := map[key] for example. So we should order it the same.

I've got the rest in an upcoming PR that also has new Validate functions as well.

How do you feel about that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that would be much more natural.

@aLekSer aLekSer force-pushed the validate-fleet-name branch from c817dc2 to 5a6542d Compare February 19, 2019 12:00
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 636be4b4-f117-4c7a-8478-916c71908ca8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the validate-fleet-name branch from 5a6542d to 0eb706b Compare February 19, 2019 12:19
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a43b1783-0516-4388-aa14-ab2a8a2b3e39

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Add Fleet and Gameserverset Validation handler
335e30e 
Add Fleet and GSS Name length check in order to prevent GSS label overflowing.
@aLekSer aLekSer force-pushed the validate-fleet-name branch from 0eb706b to 335e30e Compare February 19, 2019 12:51
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fe2bf371-ffa6-4959-8f8f-3604a79dc5ef

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/598/head:pr_598 && git checkout pr_598
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-335e30e

@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019
markmandel
markmandel approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3804d958-0a13-4826-b1ee-58f828b99813

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/598/head:pr_598 && git checkout pr_598
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-57712e4

@markmandel markmandel merged commit 3a0e6d1 into googleforgames:master Feb 21, 2019
@markmandel markmandel added this to the 0.9.0 milestone Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel