Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made strategy configurable on relevant deployments #2721

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions install/helm/agones/templates/ping.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ metadata:
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
spec:
{{- if .Values.agones.ping.updateStrategy }}
strategy:
{{- toYaml .Values.agones.ping.updateStrategy | nindent 4}}
{{- end }}
selector:
matchLabels:
agones.dev/role: ping
Expand Down
4 changes: 4 additions & 0 deletions install/helm/agones/templates/service/allocation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ metadata:
heritage: {{ .Release.Service }}
spec:
replicas: {{ .Values.agones.allocator.replicas }}
{{- if .Values.agones.allocator.updateStrategy }}
strategy:
{{- toYaml .Values.agones.allocator.updateStrategy | nindent 4}}
{{- end }}
selector:
matchLabels:
multicluster.agones.dev/role: allocator
Expand Down
2 changes: 2 additions & 0 deletions install/helm/agones/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ agones:
allocationBatchWaitTime: 500ms
ping:
install: true
updateStrategy: {}
resources: {}
# requests:
# cpu: 1
Expand Down Expand Up @@ -138,6 +139,7 @@ agones:
timeoutSeconds: 1
allocator:
install: true
updateStrategy: {}
apiServerQPS: 400
apiServerQPSBurst: 500
logLevel: info
Expand Down
8 changes: 5 additions & 3 deletions site/content/en/docs/Installation/Install Agones/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,11 @@ The following tables lists the configurable parameters of the Agones chart and t

{{% feature publishVersion="1.26.0" %}}
**New Configuration Features:**
| Parameter | Description | Default |
| -------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------- | ---------------------- |
| | | |
| Parameter | Description | Default |
| -------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- | ---------------------- |
| `agones.allocator.updateStrategy` | The [strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) to apply to the ping deployment | `{}` |
| `agones.ping.updateStrategy` | The [strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) to apply to the allocator deployment | `{}` |

{{% /feature %}}

[toleration]: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
Expand Down