Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made strategy configurable on relevant deployments #2721

Conversation

valentintorikian
Copy link
Contributor

@valentintorikian valentintorikian commented Aug 26, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Making strategy configurable for the allocator and ping services will give the ability to be more flexible in the way the deployments upgrade are performed in live clusters.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@valentintorikian valentintorikian force-pushed the configurable-deployment-strategies branch from befd4e8 to f7061a9 Compare August 26, 2022 17:01
@google-oss-prow google-oss-prow bot added size/XXL and removed size/S labels Aug 26, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: acfd2a5c-9edc-461f-ad3e-f4ce8e5de71d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1e39ff3f-03ab-43b4-993e-f11548ced4c9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2721/head:pr_2721 && git checkout pr_2721
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-f7061a9-amd64

@valentintorikian valentintorikian force-pushed the configurable-deployment-strategies branch from f7061a9 to fa555b1 Compare August 26, 2022 23:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6d183c85-292c-4a8b-bbcc-c7dc67db7ebb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2721/head:pr_2721 && git checkout pr_2721
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-fa555b1-amd64

@roberthbailey
Copy link
Member

Thanks for sending a pull request!

It looks like this change adds the file install/helm/agones/output.yaml with over 15k lines. Was that intentional? What is the purpose of that file?

@valentintorikian
Copy link
Contributor Author

Thanks for sending a pull request!

It looks like this change adds the file install/helm/agones/output.yaml with over 15k lines. Was that intentional? What is the purpose of that file?

Sorry about that. A debug artifact that went through, will remove asap.

@valentintorikian valentintorikian force-pushed the configurable-deployment-strategies branch from fa555b1 to 69e4d21 Compare August 27, 2022 12:07
@google-oss-prow google-oss-prow bot added size/S and removed size/XXL labels Aug 27, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d50ad9de-9d7f-46f4-9e72-2f278f46be84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2721/head:pr_2721 && git checkout pr_2721
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-69e4d21-amd64

@SaitejaTamma SaitejaTamma added the kind/feature New features for Agones label Aug 27, 2022
@valentintorikian valentintorikian force-pushed the configurable-deployment-strategies branch from 69e4d21 to fcaa72f Compare August 30, 2022 11:55
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 02a21b97-b51d-4ab7-bd16-ff62d91ca4e2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2721/head:pr_2721 && git checkout pr_2721
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-fcaa72f-amd64

- Updated chart templates and values
- Update documentation
@valentintorikian valentintorikian force-pushed the configurable-deployment-strategies branch from fcaa72f to 639f5fe Compare August 31, 2022 00:41
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 773a4ea3-8349-464f-8e08-f215fe79b599

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2721/head:pr_2721 && git checkout pr_2721
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-639f5fe-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Aug 31, 2022
@markmandel markmandel merged commit aa12d63 into googleforgames:main Aug 31, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, valentintorikian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants