Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated command for make minikube-push #2624

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Fix deprecated command for make minikube-push #2624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f267b
Fix deprecated command for make minikube-push
govargo Jun 10, 2022
d4003e7
Merge branch 'main' into fix-make-minikube-push
markmandel Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions build/includes/minikube.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ minikube-shell: $(ensure-build-image)
# Push the local Agones Docker images that have already been built
# via `make build` or `make build-images` into the "agones" minikube instance.
minikube-push:
$(MINIKUBE) cache add $(sidecar_linux_amd64_tag)
$(MINIKUBE) cache add $(controller_tag)
$(MINIKUBE) cache add $(ping_tag)
$(MINIKUBE) cache add $(allocator_tag)
$(MINIKUBE) image load $(sidecar_linux_amd64_tag) -p $(MINIKUBE_PROFILE)
$(MINIKUBE) image load $(controller_tag) -p $(MINIKUBE_PROFILE)
$(MINIKUBE) image load $(ping_tag) -p $(MINIKUBE_PROFILE)
$(MINIKUBE) image load $(allocator_tag) -p $(MINIKUBE_PROFILE)

# Installs the current development version of Agones into the Kubernetes cluster.
# Use this instead of `make install`, as it disables PullAlways on the install.yaml
Expand Down