Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated command for make minikube-push #2624

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Fix deprecated command for make minikube-push #2624

merged 2 commits into from
Jun 10, 2022

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Jun 10, 2022

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

When I deploved agones and tried to use minikube cluster, I found the deprecated warning for minikube cache.
And current make minikube-push command will push to minikube profile, because the profile agones is not defined.

This PR fix to use minikube image load and add the cluster profile.

% make minikube-push
minikube cache add gcr.io/agones-images/agones-sdk:1.24.0-3e5f17f-linux-amd64
❗  "minikube cache" will be deprecated in upcoming versions, please switch to "minikube image load"

❌  ...cluster "minikube" does not exist

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

If you think $(MINIKUBE_PROFILE) is not needed, please let me know.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c7be6da-b786-4059-af5d-a5d24f0cd6fc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2624/head:pr_2624 && git checkout pr_2624
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-25f267b-amd64

@google-oss-prow google-oss-prow bot added approved and removed lgtm labels Jun 10, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1c79374f-a875-489b-9bc0-d91a7c95b23a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2624/head:pr_2624 && git checkout pr_2624
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-d4003e7-amd64

@roberthbailey roberthbailey merged commit 13f31a3 into googleforgames:main Jun 10, 2022
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
@SaitejaTamma SaitejaTamma added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 14, 2022
@govargo govargo deleted the fix-make-minikube-push branch October 28, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants