-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated command for make minikube-push #2624
Fix deprecated command for make minikube-push #2624
Conversation
Build Succeeded 👏 Build Id: 3c7be6da-b786-4059-af5d-a5d24f0cd6fc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: govargo, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 1c79374f-a875-489b-9bc0-d91a7c95b23a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
When I deploved agones and tried to use minikube cluster, I found the deprecated warning for
minikube cache
.And current
make minikube-push
command will push tominikube
profile, because the profileagones
is not defined.This PR fix to use
minikube image load
and add the cluster profile.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
If you think
$(MINIKUBE_PROFILE)
is not needed, please let me know.