Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang-ci lint version and fix lint errors #2295

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Update golang-ci lint version and fix lint errors #2295

merged 3 commits into from
Oct 7, 2021

Conversation

rajat-mangla
Copy link
Contributor

@rajat-mangla rajat-mangla commented Oct 6, 2021 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: It updates the golang-ci lint to the latest version v1.42.1

Which issue(s) this PR fixes:

Closes #2220

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Oct 6, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 6, 2021
@google-cla
Copy link

google-cla bot commented Oct 6, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 6, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2eca4272-24bc-440a-9223-494e44e5676a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2295/head:pr_2295 && git checkout pr_2295
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-f72b552

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d783045e-fd34-4425-848e-be97bf21c79e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2295/head:pr_2295 && git checkout pr_2295
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-ac66af4

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 37c0429d-8dbd-4fa8-82ec-8ccbf78b81c9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2295/head:pr_2295 && git checkout pr_2295
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-bacda30

@markmandel
Copy link
Member

This LGTM.

@roberthbailey any objection to merging while we are in freeze? It's only comment changes, and one small code change. Figure it's just cleanup at this point.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajat-mangla, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 7, 2021
@roberthbailey roberthbailey added this to the 1.18.0 milestone Oct 7, 2021
@roberthbailey
Copy link
Member

I agree that this is cleanup (and I've labeled it as such). I'm happy to merge this during code freeze.

@roberthbailey roberthbailey mentioned this pull request Oct 7, 2021
Closed
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 60c2eed0-da79-4fda-8d27-c69399439db7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

I filed a bug for the flaky test.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 868b0802-6029-48d0-b8cf-02148ddec915

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bcf56794-8e31-4db6-8d35-e4c903965000

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 15688f66-60b2-4107-9606-fdcc6709531b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

We are getting some really bad luck on the flaky tests.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a84760f1-ee29-47d1-8183-87fcf27b7e53

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2295/head:pr_2295 && git checkout pr_2295
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.18.0-9b11413

@roberthbailey
Copy link
Member

roberthbailey commented Oct 7, 2021 •
edited
Loading

There it goes.

@roberthbailey roberthbailey merged commit c74d6f3 into googleforgames:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Update https://github.com/golangci/golangci-lint
5 participants
@rajat-mangla @agones-bot @markmandel @google-oss-robot @roberthbailey