Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version #2222

Closed
wants to merge 1 commit into from
Closed

Updated version #2222

wants to merge 1 commit into from

Conversation

himanshu007-creator
Copy link

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

kind feature

/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes: #2220

Closes #2220

Special notes for your reviewer:

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: himanshu007-creator
To complete the pull request process, please assign markmandel after the PR has been reviewed.
You can assign the PR to them by writing /assign @markmandel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 65413fcc-a621-41c0-95a7-102daadcef27

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Looks like the new version of the linter found a few new things!

pkg/apis/autoscaling/v1/fleetautoscaler.go:236:3: commentFormatting: put a space between `//` and comment text (gocritic)
		//Check that CABundle provided is correctly encoded certificate
		^
test/e2e/fleet_test.go:129:2: commentFormatting: put a space between `//` and comment text (gocritic)
	//Use scaleFleetPatch (true) or scaleFleetSubresource (false)
	^
test/e2e/fleet_test.go:225:2: commentFormatting: put a space between `//` and comment text (gocritic)
	//Use scaleFleetPatch (true) or scaleFleetSubresource (false)
	^
pkg/fleets/controller.go:525:12: appendAssign: append result not assigned to the same slice (gocritic)
	allGSS := append(rest, active)
	          ^
make: *** [lint] Error 1
Makefile:362: recipe for target 'lint' failed

If you want to run the linter locally, use make lint and that will run everything for you 👍🏻

@roberthbailey
Copy link
Member

himanshu007-creator - Is there anything we can do to help you progress this PR forward?

@himanshu007-creator
Copy link
Author

himanshu007-creator - Is there anything we can do to help you progress this PR forward?

I got your point @roberthbailey , I'll be surely doing the required by end of this week👍🏽,
Sorry for the delay

@roberthbailey
Copy link
Member

No worries about the delay. I was just going through PRs and want to close out those that are no longer active.

@roberthbailey roberthbailey added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Oct 5, 2021
@roberthbailey
Copy link
Member

This PR hasn't been updated in a while and has now been superseded by #2295, so I'm going to go ahead and close it.

@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc and removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Oct 7, 2021
@himanshu007-creator
Copy link
Author

@roberthbailey hi!,
I am sorry for such behavior. I had serious health issues and couldn't;t be much active for a while.

@roberthbailey
Copy link
Member

No worries. Once you are feeling better there are plenty of good starter issues you can tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update https://github.com/golangci/golangci-lint
5 participants