Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the website to use simple-game-server version 0.3. #2049

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it: Updates the website to use the new example image version.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

I found that there is a variable that should update this everywhere, but that we still had a few places where the specific version number was hard-coded. I think I found and replaced all of them (leaving the old blog pages alone) so that this process will be a single line change in the future.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b13cf83f-135d-4b58-b5a1-ecc088d8e813

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

/assign @pooneh-m

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b8fd5671-280a-4608-a7d1-814862846923

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2049/head:pr_2049 && git checkout pr_2049
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-324d067

@@ -32,7 +32,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: gcr.io/agones-images/simple-game-server:0.2
image: {{< example-image >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be example_image_tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 40fba6b into googleforgames:main Apr 6, 2021
@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
@roberthbailey roberthbailey deleted the simple-game-server-3 branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants