-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the website to use simple-game-server version 0.3. #2049
Update the website to use simple-game-server version 0.3. #2049
Conversation
Build Failed 😱 Build Id: b13cf83f-135d-4b58-b5a1-ecc088d8e813 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/assign @pooneh-m |
Build Succeeded 👏 Build Id: b8fd5671-280a-4608-a7d1-814862846923 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -32,7 +32,7 @@ spec: | |||
spec: | |||
containers: | |||
- name: simple-game-server | |||
image: gcr.io/agones-images/simple-game-server:0.2 | |||
image: {{< example-image >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be example_image_tag
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's using the example image shortcode: https://github.com/googleforgames/agones/blob/main/site/layouts/shortcodes/example-image.html
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pooneh-m, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / Why we need it: Updates the website to use the new example image version.
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
I found that there is a variable that should update this everywhere, but that we still had a few places where the specific version number was hard-coded. I think I found and replaced all of them (leaving the old blog pages alone) so that this process will be a single line change in the future.