Fix bug in webhook docs after example switch #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realise the webhook examples weren't under the ./examples/simple-game-server folder, and as such weren't already updated for the 1.12.0 release branch. So this broke the examples for webhooks, as they still pointed at the `simple-udp` Fleet. Doing a temporary redirect of the yaml examples to `main` for these quickstart examples until the next release to resolve the issue.
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: fed9b354-d4f5-4ec7-83b8-a62ed1a8a0d4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Feb 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
I didn't realise the webhook examples weren't under the ./examples/simple-game-server folder, and as such weren't already updated for the 1.12.0 release branch.
So this broke the examples for webhooks, as they still pointed at the
simple-udpFleet.Doing a temporary redirect of the yaml examples to
mainfor these quickstart examples until the next release to resolve the issue.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A