Skip to content

Commit

Permalink
Fix bug in webhook docs after example switch (#1996)
Browse files Browse the repository at this point in the history
I didn't realise the webhook examples weren't under the
./examples/simple-game-server folder, and as such weren't already
updated for the 1.12.0 release branch.

So this broke the examples for webhooks, as they still pointed at the
`simple-udp` Fleet.

Doing a temporary redirect of the yaml examples to `main` for these
quickstart examples until the next release to resolve the issue.
  • Loading branch information
markmandel authored Feb 16, 2021
1 parent 7afab5c commit 48381f1
Showing 1 changed file with 16 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,16 @@ Status: Running

Let's create a Fleet Autoscaler using the following command:

{{% feature expiryVersion="1.13.0" %}}
```
kubectl apply -f https://raw.githubusercontent.com/googleforgames/agones/main/examples/webhookfleetautoscaler.yaml
```
{{% /feature %}}
{{% feature publishVersion="1.13.0" %}}
```
kubectl apply -f https://raw.githubusercontent.com/googleforgames/agones/{{< release-branch >}}/examples/webhookfleetautoscaler.yaml
```
{{% /feature %}}

You should see a successful output similar to this:

Expand Down Expand Up @@ -347,10 +354,19 @@ base64 -i ./rootCA.pem
```

Copy the output of the command above and replace the caBundle field in your text editor (say vim) with the new value:

{{% feature expiryVersion="1.13.0" %}}
```
wget https://raw.githubusercontent.com/googleforgames/agones/main/examples/webhookfleetautoscalertls.yaml
vim ./webhookfleetautoscalertls.yaml
```
{{% /feature %}}
{{% feature publishVersion="1.13.0" %}}
```
wget https://raw.githubusercontent.com/googleforgames/agones/{{< release-branch >}}/examples/webhookfleetautoscalertls.yaml
vim ./webhookfleetautoscalertls.yaml
```
{{% /feature %}}

#### 3. Deploy a Webhook service for autoscaling

Expand Down

0 comments on commit 48381f1

Please sign in to comment.