-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed getting latency metrics #1969
Conversation
3409634
to
e16197d
Compare
Build Failed 😱 Build Id: 68ac752c-e1f3-4ed7-bfae-69d1cd828a30 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 579c8886-9805-491b-bf79-98a04c05ade2 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
e16197d
to
46af90d
Compare
Build Succeeded 👏 Build Id: 5ee57d57-c29f-4a19-bb32-4ce5ed2d1c60 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This looks good to me, a couple of questions, one thought: If you have them, can you take a screenshot of the metrics showing up in a dashboard? Just good for audit trails (I can fire it up and install it, but figured you might have it handy). But otherwise, no issue on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 8398a7, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 276fb059-9629-442c-8086-c7259b5dbac7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Because the gRPC endpoint cannot get latency metrics.
Which issue(s) this PR fixes:
Closes #1855
Special notes for your reviewer: