Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getting latency metrics #1969

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

8398a7
Copy link
Contributor

@8398a7 8398a7 commented Jan 27, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Because the gRPC endpoint cannot get latency metrics.

Which issue(s) this PR fixes:

Closes #1855

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 68ac752c-e1f3-4ed7-bfae-69d1cd828a30

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 579c8886-9805-491b-bf79-98a04c05ade2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@8398a7 8398a7 force-pushed the fix-latency-metrics branch from e16197d to 46af90d Compare January 27, 2021 14:15
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5ee57d57-c29f-4a19-bb32-4ce5ed2d1c60

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1969/head:pr_1969 && git checkout pr_1969
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-46af90d

@8398a7 8398a7 changed the title Fixed getting latency metrics (#1855) Fixed getting latency metrics Jan 28, 2021
@markmandel markmandel added the kind/bug These are bugs. label Jan 29, 2021
@markmandel
Copy link
Member

This looks good to me, a couple of questions, one thought:
Do we want some kind of unit test with this, just to make sure the metrics stay in place and do what we expect?

If you have them, can you take a screenshot of the metrics showing up in a dashboard? Just good for audit trails (I can fire it up and install it, but figured you might have it handy).

But otherwise, no issue on my end.

@8398a7
Copy link
Contributor Author

8398a7 commented Feb 1, 2021

image

I couldn't think of a way to write a good unit test, so I submitted a screenshot.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 8398a7, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 276fb059-9629-442c-8086-c7259b5dbac7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1969/head:pr_1969 && git checkout pr_1969
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-2d6be05

@markmandel markmandel merged commit 1cc5d8a into googleforgames:master Feb 2, 2021
@markmandel markmandel added this to the 1.12.0 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC allocate can't get some metrics
4 participants