Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq links point to wrong place #1549

Merged
merged 1 commit into from
May 14, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Not sure how this passed in the first place, but the FAQ links should
points to the SDK, not REST API.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Not sure how this passed in the first place, but the FAQ links should
points to the SDK, not REST API.
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood where these links come from, now it is better.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 607ac0d5-e261-471a-8aad-5241866f3ad7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1549/head:pr_1549 && git checkout pr_1549
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-a38ab7f

@markmandel markmandel merged commit 67eb60c into googleforgames:master May 14, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 14, 2020
@markmandel markmandel deleted the bug/site-faq-links branch May 14, 2020 20:28
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Not sure how this passed in the first place, but the FAQ links should
points to the SDK, not REST API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug These are bugs. kind/documentation Documentation for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants