Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation for multi-cluster allocation #1365

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Updated documentation for multi-cluster allocation #1365

merged 2 commits into from
Mar 1, 2020

Conversation

pooneh-m
Copy link
Contributor

Added a sample for allocator gRPC client. Also,
Closes #1301
Closes #1333

@pooneh-m pooneh-m removed the request for review from cyriltovena February 26, 2020 05:01
@pooneh-m pooneh-m mentioned this pull request Feb 26, 2020
Closed
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 87cef1c3-4a1f-4790-b1ed-1e49e0472cf8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1365/head:pr_1365 && git checkout pr_1365
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-5ebc802

markmandel
markmandel reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments - but we can integrate all this post RC release today.

👍 Nice stuff!

examples/allocator-client/main.go Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/allocator-service.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md Outdated Show resolved Hide resolved
site/content/en/docs/Advanced/multi-cluster-allocation.md
curl https://${EXTERNAL_IP}:443/v1alpha/gameserverallocation \
--header "Content-Type: application/json" \
-d '{"namespace": "'${NAMESPACE}'", "multiClusterSetting": {"enabled": true}, "requiredGameServerSelector": {"matchLabels": {"agones.dev/fleet": "'${FLEET_NAME}'"}}}' \
go run examples/allocator-client/main.go --ip ${EXTERNAL_IP} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this. This is so awesome 🔥

@pooneh-m pooneh-m requested a review from markmandel February 26, 2020 22:32
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b8f6a0f0-9337-4aac-a081-f8cd889f04d7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f3243aca-6750-4070-9230-a7f3b1e33bb4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 36505556-97f6-4fc0-a2be-26b51eaceb72

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1365/head:pr_1365 && git checkout pr_1365
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a7473ed

markmandel
markmandel approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤸‍♂️ Love it.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e1c25713-aff3-4114-a3aa-801226f8b843

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1365/head:pr_1365 && git checkout pr_1365
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-3f7a3ca

@markmandel markmandel merged commit 619867f into googleforgames:master Mar 1, 2020
@markmandel markmandel added kind/breaking Breaking change kind/documentation Documentation for Agones kind/feature New features for Agones labels Mar 1, 2020
@markmandel markmandel added this to the 1.4.0 milestone Mar 1, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @markmandel @ilkercelikyilmaz
Updated documentation for multi-cluster allocation (googleforgames#1365)
4bc6009 
Co-authored-by: Mark Mandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees

@markmandel markmandel

Labels
approved kind/breaking Breaking change kind/documentation Documentation for Agones kind/feature New features for Agones size/L
Projects
None yet
Milestone
1.4.0
4 participants
@pooneh-m @agones-bot @google-oss-robot @markmandel