Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for gRPC Based Multicluster Allocator #1333

Closed
markmandel opened this issue Feb 11, 2020 · 5 comments · Fixed by #1365
Closed

Documentation for gRPC Based Multicluster Allocator #1333

markmandel opened this issue Feb 11, 2020 · 5 comments · Fixed by #1365
Assignees
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone

Comments

@markmandel
Copy link
Member

Now we have switched to a gRPC based allocator https://agones.dev/site/docs/advanced/multi-cluster-allocation/#allocate-multi-cluster is now incorrect, as the documentation provided still uses HTTPS.

I wonder if we can use something like https://github.com/grpc-ecosystem/polyglot or https://github.com/fullstorydev/grpcurl to replace the curl command?

@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Feb 11, 2020
@markmandel
Copy link
Member Author

@pooneh-m is this possible to be fixed before RC on Tuesday? Otherwise we're going to have erroneous documentation 😞

@markmandel
Copy link
Member Author

Also, the links in https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Advanced/multi-cluster-allocation.md to the github URLs.

Should use a ghlink shotcode, will 404 once the link checker cache expires, as they point to master rather than a release branch, and we moved that CRD to v1

@pooneh-m
Copy link
Contributor

Thanks @markmandel. The change is only for documentation. In case I couldn't update documentation by RC date, we should have time before the release to update documentation, correct?
Thanks for ghlink pointer

@markmandel
Copy link
Member Author

Sounds good. Ideally it would be great to have before RC, so people could check it out, but if not, before stable, during the feature freeze week works too.

@pooneh-m
Copy link
Contributor

Thanks. I'll do my best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
2 participants