Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): skip fixing poms for special modules #1744

Merged
merged 3 commits into from
Jan 19, 2023
+7 −0
Merged

fix(java): skip fixing poms for special modules #1744

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
630afb6
fix(java): handle empty modules
suztomo Jan 11, 2023
d43ae9d
Merge branch 'master' into java_handle_empty_modules
suztomo Jan 19, 2023
b0ff90f
Merge branch 'master' into java_handle_empty_modules
suztomo Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docker/owlbot/java/src/fix-poms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ def main():
)
main_module = existing_modules[artifact_id]

if artifact_id in ["grafeas", "google-cloud-dns",
"google-cloud-notification"]:
# There are special libraries that are not automatically generated
print(f"Skipping a special case library {artifact_id} that do not have "
" the standard module structure.")
return

parent_artifact_id = f"{artifact_id}-parent"

if parent_artifact_id not in existing_modules:
Expand Down