Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): skip fixing poms for special modules #1744

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fix(java): skip fixing poms for special modules #1744

merged 3 commits into from
Jan 19, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 11, 2023

Fixes #1743

@suztomo suztomo requested a review from a team as a code owner January 11, 2023 19:57
@suztomo suztomo marked this pull request as draft January 11, 2023 19:57
@suztomo suztomo force-pushed the java_handle_empty_modules branch from 0e46aa6 to e437de3 Compare January 11, 2023 20:19
@suztomo suztomo force-pushed the java_handle_empty_modules branch from e437de3 to 630afb6 Compare January 11, 2023 20:19
@suztomo suztomo changed the title fix(java): handle empty modules fix(java): skip fixing poms for special modules Jan 11, 2023
@suztomo
Copy link
Member Author

suztomo commented Jan 11, 2023

owlbot-java-presubmit is failing https://screenshot.googleplex.com/BtUr8xp8pM7ZrvS.png

@suztomo
Copy link
Member Author

suztomo commented Jan 11, 2023

It turned out that it's due to Java 8 container update. Lawrence's #1741 should come first. But that's after current release.

@suztomo suztomo mentioned this pull request Jan 11, 2023
Merged
1 task
@suztomo suztomo marked this pull request as ready for review January 19, 2023 19:09
@suztomo suztomo enabled auto-merge (squash) January 19, 2023 20:19
@suztomo suztomo merged commit 482d649 into googleapis:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees

@chingor13 chingor13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java] OwlBot PostProcessor fails to work with java-grafeas module
3 participants
@suztomo @lqiu96 @chingor13